Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deposit params to desired config #46

Closed
wants to merge 1 commit into from
Closed

Conversation

0xmichalis
Copy link
Member

@0xmichalis 0xmichalis commented Feb 28, 2024

Update to the final desired configuration so we won't have to execute the setters

@kosecki123
Copy link
Contributor

This is fine change but all test will fail as they been recalculated to other params.

@0xmichalis 0xmichalis force-pushed the params-update branch 2 times, most recently from 3fdbc5c to 037ffd2 Compare February 29, 2024 11:27
@0xmichalis
Copy link
Member Author

Most tests fixed, still need to figure out why three fuzzing tests fail:

Failing tests:
Encountered 3 failing tests in test/FeeCalculator.fuzzy.t.sol:FeeCalculatorTestFuzzy
[FAIL. Reason: revert: Deposit outside range; counterexample: calldata=0xfd2f487e000000000000000000000000000000000000000000000000000000000000281b000000000000000000000000000000000000000000000000000000000000238200000000000000000000000000000000000000000000000000000000000033fe args=[10267 [1.026e4], 9090, 13310 [1.331e4]]] testCalculateDepositFeesFuzzy(uint256,uint256,uint256) (runs: 4, μ: 102549, ~: 109883)
[FAIL. Reason: assertion failed; counterexample: calldata=0x189060f000000000000000000000000000000000000000000000000000000000000000fc0000000000000000000000000000000000000000000000003782dace9d8ffffe000000000000000000000000000000000000000000000000000000000000238d00000000000000000000000000000000000000000000000000000000000027ae args=[252, 3999999999999999998 [3.999e18], 9101, 10158 [1.015e4]]] testCalculateDepositFeesFuzzy_DepositDividedIntoMultipleChunksFeesGreaterOrEqualToOneDeposit(uint8,uint256,uint256,uint256) (runs: 0, μ: 0, ~: 0)
[FAIL. Reason: assertion failed; counterexample: calldata=0x14ba6c4c000000000000000000000000000000000000000000000000000000e8d4a5100100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001 args=[1000000000001 [1e12], 0, 1]] testCalculateDepositFeesFuzzy_DepositDividedIntoOneChunkFeesGreaterOrEqualToOneDeposit(uint256,uint256,uint256) (runs: 1, μ: 104866, ~: 104866)

@0xmichalis
Copy link
Member Author

Closing since we are tracking this in Linear

@0xmichalis 0xmichalis deleted the params-update branch June 5, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants