Pin contract versions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a recommended practice by security auditors, also prb-math requires 0.8.19 version so pin the main fee calculator contract to 0.8.19. This change aligns the OZ contract version with the version used in the rest of the Toucan protocols which will reduce the effort we will need to spend during auditing.
0xmichalis
force-pushed
the
pin-version
branch
from
6351e43 to
c852406
Compare
PawelTroka
reviewed
Dec 21, 2023
| @@ -36,7 +36,7 @@ contract FeeCalculator is IFeeCalculator, Ownable { | |||
| address[] private _recipients; | |||
| uint256[] private _shares; | |||
|
|
|||
| constructor() Ownable(msg.sender) {} | |||
| constructor() Ownable() {} | |||
There was a problem hiding this comment.
okk, so in this version of Ownable we dont have to pass owner address, instead it is being taken from deployer, right?
There was a problem hiding this comment.
Exactly, it uses _msgSender() by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a recommended practice by security
auditors, also prb-math requires 0.8.19 version
so pin the main fee calculator contract to 0.8.19.
This change aligns the OZ contract version with
the version used in the rest of the Toucan protocols
which will reduce the effort we will need to spend
during auditing.