Small chores #14
Merged
Small chores #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restFee is already a uint256 so Solidity will revert in case we try to set a negative number to it.
|
@PawelTroka sorry, I've pushed a couple of more changes, ptal |
Aligns with `calculateDepositFees`
PawelTroka
reviewed
Nov 27, 2023
| @@ -30,6 +30,10 @@ jobs: | |||
| forge build --sizes --via-ir | |||
| id: build | |||
|
|
|||
| - name: Check formatting | |||
PawelTroka
reviewed
Nov 27, 2023
| /// @return recipients The addresses of the fee recipients. | ||
| /// @return feesDenominatedInPoolTokens The amount of fees each recipient should receive. | ||
| function calculateRedemptionFee(address tco2, address pool, uint256 depositAmount) | ||
| function calculateRedemptionFees(address tco2, address pool, uint256 redemptionAmount) |
There was a problem hiding this comment.
cool, I also wanted to change that :)
PawelTroka
reviewed
Nov 27, 2023
| } catch Error(string memory reason) { | ||
| assertEq("Fee must be greater than 0", reason); | ||
| } | ||
| vm.expectRevert("Fee must be greater than 0"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.