Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feeSetup needs to be guarded #13

Closed
0xmichalis opened this issue Nov 23, 2023 · 1 comment
Closed

feeSetup needs to be guarded #13

0xmichalis opened this issue Nov 23, 2023 · 1 comment
Assignees
@PawelTroka

Comments

@0xmichalis
Copy link
Member

Currently feeSetup can be called by anyone. I suggest we update the contract to be Ownable then only the contract owner should be allowed to call feeSetup. A multisig co-owned by Neutral and Toucan could then be set up in mainnet as the contract owner.

https://github.com/neutral-protocol/dynamic-fee-pools/blob/fec047ceef8e4a610f919ac350b894bae672ea4b/src/FeeCalculator.sol#L36
@PawelTroka PawelTroka self-assigned this Nov 29, 2023
@PawelTroka
Copy link
Contributor

done via #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PawelTroka PawelTroka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xmichalis @PawelTroka