Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix union-type handling in PublicStaticPropertyFetchCollector #121

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Fix union-type handling in PublicStaticPropertyFetchCollector #121

merged 4 commits into from
Jul 15, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 15, 2024

analog #120

staabm
staabm commented Jul 15, 2024
View reviewed changes
src/Collectors/PublicStaticPropertyFetchCollector.php
if ($node->class->toString() === 'self') {
// self fetch is allowed
$classReflection = $scope->getClassReflection();
if ($classReflection instanceof ClassReflection && $this->classTypeDetector->isTestClass($classReflection)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this collector was missing the "test-only" detection part

@staabm staabm marked this pull request as ready for review July 15, 2024 11:56
@staabm
Copy link
Contributor Author

staabm commented Jul 15, 2024

should be good to go

@TomasVotruba TomasVotruba merged commit 5da0ca6 into TomasVotruba:main Jul 15, 2024
8 checks passed
@TomasVotruba
Copy link
Owner

Thanks 😊👍

@staabm staabm deleted the static branch July 15, 2024 12:05
@staabm
Copy link
Contributor Author

staabm commented Jul 15, 2024

would be great to get a new release. I have no further known problems to work on :-)

neoighodaro added a commit to neoighodaro/unused-public that referenced this pull request Nov 21, 2024
@neoighodaro
Merge branch 'TomasVotruba-main'
d86448a 
* TomasVotruba-main: (21 commits)
  Delete .github/FUNDING.yml
  Update FUNDING.yml
  Update composer.json
  Keep the code DRY
  Small improvement
  Added support for @internal or @public
  Reduce memory consumption of collectors (TomasVotruba#131)
  Fix blade regex to discover method call with args (TomasVotruba#128)
  Fix template discovery, to include root file too (TomasVotruba#127)
  remove `composer-dependency-analyser.php` from releases (TomasVotruba#126)
  Bump deps (TomasVotruba#125)
  Detect public properties used via Subclass (TomasVotruba#123)
  Fix ClassConstFetchCollector (TomasVotruba#122)
  Fix union-type handling in PublicStaticPropertyFetchCollector (TomasVotruba#121)
  Fix union-type handling in PublicPropertyFetchCollector (TomasVotruba#120)
  add phpstan error identifiers (TomasVotruba#118)
  Fixed nette/utils indirect dependency (TomasVotruba#116)
  Added test for JsonSerialize (TomasVotruba#112)
  Add RelativeUnusedPublicClassMethodRule (TomasVotruba#111)
  Bump to PHP 8.2 (TomasVotruba#110)
  ...
neoighodaro added a commit to neoighodaro/unused-public that referenced this pull request Nov 21, 2024
@neoighodaro
Merge remote-tracking branch 'origin/main'
476b23e 
* origin/main: (22 commits)
  Allow phpstan 2
  Delete .github/FUNDING.yml
  Update FUNDING.yml
  Update composer.json
  Keep the code DRY
  Small improvement
  Added support for @internal or @public
  Reduce memory consumption of collectors (TomasVotruba#131)
  Fix blade regex to discover method call with args (TomasVotruba#128)
  Fix template discovery, to include root file too (TomasVotruba#127)
  remove `composer-dependency-analyser.php` from releases (TomasVotruba#126)
  Bump deps (TomasVotruba#125)
  Detect public properties used via Subclass (TomasVotruba#123)
  Fix ClassConstFetchCollector (TomasVotruba#122)
  Fix union-type handling in PublicStaticPropertyFetchCollector (TomasVotruba#121)
  Fix union-type handling in PublicPropertyFetchCollector (TomasVotruba#120)
  add phpstan error identifiers (TomasVotruba#118)
  Fixed nette/utils indirect dependency (TomasVotruba#116)
  Added test for JsonSerialize (TomasVotruba#112)
  Add RelativeUnusedPublicClassMethodRule (TomasVotruba#111)
  ...
ngmy pushed a commit to ngmy/unused-public that referenced this pull request Dec 19, 2024
@staabm @ngmy
Fix union-type handling in PublicStaticPropertyFetchCollector (TomasV…
f3b7b34 
…otruba#121)

* Fix union-type handling in PublicStaticPropertyFetchCollector

* another test

* fix namespace

* Update UnusedPublicPropertyRuleTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @TomasVotruba