Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more diff tests. #1000

Merged
merged 1 commit into from
Feb 19, 2025
Merged

feat: Add more diff tests. #1000

merged 1 commit into from
Feb 19, 2025

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 17, 2025

These help make sure all repos have the same configs.

Also, reworked the caching to use GitHub release assets instead of an actual remote cache.


This change is Reviewable

@iphydf iphydf added this to the master milestone Feb 18, 2025
@iphydf iphydf force-pushed the yamls branch 8 times, most recently from eef2a15 to d87d8f6 Compare February 19, 2025 00:00
@iphydf iphydf marked this pull request as ready for review February 19, 2025 00:01
@iphydf iphydf requested a review from a team as a code owner February 19, 2025 00:01
@iphydf iphydf force-pushed the yamls branch 2 times, most recently from e2e69f8 to 78a43d7 Compare February 19, 2025 00:14
Copy link
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update all the things

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 62 of 62 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained

These help make sure all repos have the same configs.
@iphydf iphydf merged commit afb78a5 into TokTok:master Feb 19, 2025
14 checks passed
@iphydf iphydf deleted the yamls branch February 19, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants