Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give_container for arbitrary container builders #621

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

antiguru
Copy link
Member

Previously, we'd only support Session::give_container for capacity container builders, but there is no reason not to offer it for all builders. Here, we change the definition to apply for all session and buffers. The implementation ensures FIFO order by flushing before pushing a whole prefabricated container.

Signed-off-by: Moritz Hoffmann antiguru@gmail.com

Previously, we'd only support `Session::give_container` for capacity
container builders, but there is no reason not to offer it for all
builders. Here, we change the definition to apply for all session and
buffers. The implementation ensures FIFO order by flushing before pushing
a whole prefabricated container.

Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
@frankmcsherry
Copy link
Member

This looks good to me, thanks!

@frankmcsherry frankmcsherry merged commit 3a90720 into TimelyDataflow:master Jan 15, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
@antiguru antiguru deleted the give_container branch January 15, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants