Create Subarray object library. #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekadavis9
force-pushed
the
rd/OLs-subarray
branch
from
73937d8
to
611cac6
Compare
bekadavis9
force-pushed
the
rd/OLs-subarray
branch
from
878ca2f
to
eb50bed
Compare
bekadavis9
force-pushed
the
rd/OLs-subarray
branch
from
eb50bed
to
60cb5fd
Compare
There was a problem hiding this comment.
I noticed that moving the subarray tests to standalone was reverted because:
- The find heap API violations workflow failed because of some usages of
unique_ptrin the tests. You can either migrate them to usetdb_unique_ptror update the script to exclude test code (I wouldn't have a problem with it personally). - There were some warnings-turned-errors about usages of the deprecated
dumpC APIs (which happened inside the deprecated C++ APIs and it doesn't make sense to warn if you'd ask me). You can fix them by adding a#define TILEDB_REMOVE_DEPRECATIONSat the top of the files.
It would be nice if you could move the tests in this PR.
|
@teo-tsirpanis I decided it would be best not to come up with a potentially-hacky fix for the heap violations issue. I wanted to address that in a separate PR, with a more well thought-out design. Further, none of the other OL PRs have yet migrated unit tests, so the behavior was inconsistent anyway. It's best to defer the work until the heap issue can be properly resolved, and then the unit test migration can be its own unit of work. |
|
Sounds good. |
ihnorton
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
Subarrayobject library.[sc-53884]
TYPE: NO_HISTORY
DESC: Create
Subarrayobject library.