Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plot_layout basic functionality #99

Merged
merged 2 commits into from
May 14, 2024

Conversation

cnrrobertson
Copy link
Contributor

@cnrrobertson cnrrobertson commented Apr 29, 2024

Addresses #61. This is an implementation of the patchwork plot_layout function that allows for controlling the number of rows, columns, in which direction plots are inputted (row-wise or column-wise), and their relative widths and heights. It is still missing some pieces:

  • Ability to leave an empty height or width and it be auto filled
  • Guides, tags, axes, axis_titles, and design functionalities from patchwork
  • Docs of course!

I'm not sure how much of the above is currently feasible with Makie's SpecApi tools (like manipulating shared axes between plots in a GridLayout), so it would probably have to be done as post processing somehow. Or maybe time for some upstream contribution!

In the meantime, this does work with both GGPlot and GGPlotGrid inputs but it's most straightforward to use only + operations.

@cnrrobertson cnrrobertson mentioned this pull request Apr 30, 2024
3 tasks
@rdboyes
Copy link
Member

rdboyes commented May 11, 2024

Hey @cnrrobertson - I'm inclined to merge this, close the initial issue that called for "basic patchwork functionality" and add issues to track your future changes. Is there anything stopping this from being included as it is? Its ok if its a "work in progress" - the whole package is, after all

@cnrrobertson
Copy link
Contributor Author

Sorry for the delay @rdboyes, I have been traveling. It is functional as is, so I see no reason it couldn't be merged. I can put the checklist above as a new issue.

@cnrrobertson cnrrobertson marked this pull request as ready for review May 13, 2024 18:10
@rdboyes rdboyes merged commit df5866a into TidierOrg:main May 14, 2024
5 checks passed
@rdboyes
Copy link
Member

rdboyes commented May 14, 2024

No need to apologize! I'm merging this now - thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants