Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracle support #28

Closed
wants to merge 12 commits into from
Closed

Add oracle support #28

wants to merge 12 commits into from

Conversation

drizk1
Copy link
Member

@drizk1 drizk1 commented Jun 12, 2024

No description provided.

@drizk1
Copy link
Member Author

drizk1 commented Jun 12, 2024

I am not sure why the nightly build fails, but not the other. Adding NetworkOptions.jl didnt help.. below is the extracted part form the Oracle toml. I dont see network options there so I am not sure how to make it pass the nightly build before merging.

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"

[compat]
Tables = "1"
julia = "1.6"

[extras]
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test", "DataFrames"]

and downloads does have NetworkOptions in its dependencies.

@drizk1
Copy link
Member Author

drizk1 commented Jun 13, 2024

the new error is as follows. I have no idea why, so I think oracle support will have to live here in this branch

ERROR: LoadError: ArgumentError: Package LibGit2 does not have LibGit2_jll in its dependencies:
- Note that the following manifests in the load path were resolved with a different
  julia version, which may be the cause of the error:
    /home/runner/work/TidierDB.jl/TidierDB.jl/Manifest.toml (v1.9.1)```

@drizk1
Copy link
Member Author

drizk1 commented Jun 17, 2024

I am going to close this and use ODBC.jl. I think I will leave the branch available for the time being to any user would prefer to connect with Oracle.jl.

@drizk1 drizk1 closed this Jun 17, 2024
@drizk1 drizk1 deleted the add_oracle_support branch June 17, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant