Skip to content

Commit

Permalink
remove a couple hiding print statements
Browse files Browse the repository at this point in the history
  • Loading branch information
drizk1 committed Dec 13, 2024
1 parent 4354646 commit 2cb6c73
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/joins_sq.jl
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ macro left_join(sqlquery, join_table, expr... )
and = ""
for e in expr[2:end]
if e.head == :call && e.args[1] == :closest
println("Detected closest condition")
closest_expr, as_of, and= parse_closest_expression(e)
else
error("Unsupported argument: $(e)")
Expand Down
4 changes: 2 additions & 2 deletions src/slices_sq.jl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ macro slice_min(sqlquery, column, n=1)
for cte in reverse(sq.ctes)
if !isempty(cte.groupBy)
most_recent_groupBy = cte.groupBy
println(most_recent_groupBy)
# println(most_recent_groupBy)
partition_by_clause = "PARTITION BY " * most_recent_groupBy

break
Expand Down Expand Up @@ -128,7 +128,7 @@ macro slice_max(sqlquery, column, n=1)
for cte in reverse(sq.ctes)
if !isempty(cte.groupBy)
most_recent_groupBy = cte.groupBy
println(most_recent_groupBy)
# println(most_recent_groupBy)
partition_by_clause = "PARTITION BY " * most_recent_groupBy

break
Expand Down

2 comments on commit 2cb6c73

@drizk1
Copy link
Member Author

@drizk1 drizk1 commented on 2cb6c73 Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

  • adds @relocate
  • bug fix when reading file paths with * wildcard with DuckDB + allows users to add alias table name when reading file paths with * in db_table() with optional alias = (alias otherwise sql defaults to 'file_path' AS data

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/121386

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.3 -m "<description of version>" 2cb6c739a379f393b36807bd443c8d0744363637
git push origin v0.5.3

Please sign in to comment.