Add files via upload #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revise main.py
eggry
requested changes
Mar 9, 2025
| return dataset | ||
|
|
||
|
|
||
| def eval_metrics(labels, preds): | ||
| if all(pd.isna(labels)): |
There was a problem hiding this comment.
Does this case really need to be handled in a seperate if statement? Could this be directly integrated into the original control flow?
| pd.Series([None] * len(dataset["label"]), dtype="boolean"), | ||
| dataset["label"], | ||
| ), | ||
| if not dataset["label"].isna().all(): |
There was a problem hiding this comment.
use a flag hasLabels to replace all not dataset["label"].isna().all()
There was a problem hiding this comment.
Can be refactored as results = {...} if has_labels else {}
| if k != "Annotation": | ||
| tb.add_row([k, v["labelled_coverage"], v["accuracy"], v["recall"], v["precision"], v["f1"]]) | ||
| print(tb) | ||
| if not dataset["label"].isna().all(): |
| @@ -189,11 +202,10 @@ def main( | |||
| } | |||
|
|
|||
| del evaluator | |||
| except Exception as e: | |||
| logger.error(f"Failed to evaluate {evaluator_id}: {e}") | |||
| finally: | |||
There was a problem hiding this comment.
Remove this finally will result in leakage
| "coverage": coverage, | ||
| "jailbreak_ratio": jailbreak_ratio, | ||
| "labelled_coverage": 0.00, | ||
| "accuracy": "N/A", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revise main.py
What does this PR do?
fix no label problems
Please check all applicable items before submitting: