Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: Reduce duplicates by enforcing unique autofills #241

Open
ginatrapani opened this issue Sep 9, 2015 · 3 comments
Open

Enh: Reduce duplicates by enforcing unique autofills #241

ginatrapani opened this issue Sep 9, 2015 · 3 comments
Assignees

Comments

@ginatrapani
Copy link
Member

If someone tries to add a maker or project with an autofill of a maker/project that already exists, Makerbase should stop things there.

On the backend, need to add a unique index on autofill_network and autofill_network_user_id.

On the front end, what should happen when a user tries to insert an existing person, say, from Twitter?

@ginatrapani
Copy link
Member Author

While I work on #260, realizing that anyone can add someone from Twitter to Makerbase multiple times, create multiple makers, and fire off multiple tweets. Gonna address this first to reduce the chances of that happening.

On the front end, what should happen when a user tries to insert an existing person, say, from Twitter?

Attempting to answe my own question here: on the add maker/project form, when the user presses submit and the Twitter ID is set but already exists, redirect to the existing maker or project with the error message: "This maker already exists."

Cool?

@ginatrapani
Copy link
Member Author

If the existing maker or project is archived - should the app automatically unarchive it on add?

@anildash
Copy link
Member

anildash commented Nov 3, 2015

I think just redirect is fine, no message. Probably less confusing that way. And yep, unarchive -- that's actually kinda slick, emphasizes how the data live on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants