Fix IsEnablePDFExtension to work #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `disable-pdf-extension` command line parameter is no longer supported on CEF 126.2.7+. CEF does the same behavior with specifying the preference `plugins.always_open_pdf_externally` on CEF 126+. Note that we can't use the preference `plugins.always_open_pdf_externally` on older version, at least CEF119, because it does not exist.
HashidaTKS
commented
Dec 4, 2024
| CefString error; | ||
| CefRefPtr<CefValue> value = CefValue::Create(); | ||
| value->SetBool(true); | ||
| requestContext->SetPreference("plugins.always_open_pdf_externally", value, error); |
There was a problem hiding this comment.
CEFのバージョンによらず常にこのpreferenceを指定する方法で良いのではないかと思ったが、少なくともCEF119ではこのpreferenceが存在せず警告が出て正しく動かなかったので、バージョンによる分岐を設けている。
HashidaTKS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
https://github.com/ThinBridge/Chronos-SG/issues/303
What this PR does / why we need it:
The
disable-pdf-extensioncommand line parameter is no longer supported on CEF 126.2.7+. CEF does the same behavior with specifying the preferenceplugins.always_open_pdf_externallyon CEF 126+.cefsharp/CefSharp#4880
Note that we can't use the preference
plugins.always_open_pdf_externallyon older versions, at least CEF119, because it does not exist.How to verify the fixed issue:
The steps to verify: