Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dark mode in the Console #7529

Merged
merged 22 commits into from
Mar 24, 2025
Merged

Introduce dark mode in the Console #7529

merged 22 commits into from
Mar 24, 2025

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Mar 4, 2025

Summary

This PR adds dark mode switch in the console

Changes

  • Update some component styles to have a dark theme
  • Add switch theme interaction

Testing

Steps
  1. Go to Theme under user settings on the left
  2. Select the dark
  3. See the theme change immediately
  4. Click around to make sure nothing is broken
Results
Screenshot 2025-03-04 at 16 52 21 Screenshot 2025-03-04 at 16 52 05
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Mar 4, 2025
@ryaplots ryaplots added this to the v3.34.1 milestone Mar 4, 2025
@ryaplots ryaplots requested a review from a team as a code owner March 4, 2025 15:53
Copy link
Contributor

@PavelJankoski PavelJankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on implementing this big and useful feature!

@ryaplots ryaplots merged commit 3e7984d into v3.34 Mar 24, 2025
12 of 13 checks passed
@ryaplots ryaplots deleted the feature/dark-mode branch March 24, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants