Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LastBatteryPercentage in the Application Uplink message #7494

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Jan 28, 2025

Summary

References: #7449

Changes

  • Adds battery_percentage field to the get paths

Testing

Steps

...

Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi requested a review from a team as a code owner January 28, 2025 14:20
@halimi halimi requested a review from johanstokking January 28, 2025 14:20
@github-actions github-actions bot added the c/network server This is related to the Network Server label Jan 28, 2025
@halimi halimi self-assigned this Jan 28, 2025
@halimi halimi added this to the v3.33.1 milestone Jan 28, 2025
@KrishnaIyer KrishnaIyer merged commit 7c1baed into v3.34 Jan 28, 2025
12 of 13 checks passed
@KrishnaIyer KrishnaIyer deleted the fix/7449-battery-percentage-field branch January 28, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants