From fdc6598af9f88149d8436d05afd0035165c4a9a4 Mon Sep 17 00:00:00 2001 From: MaxToffy Date: Mon, 13 Jan 2025 10:45:24 +0100 Subject: [PATCH] Fix remote dumping errors --- examples/secretsdump.py | 2 ++ impacket/winregistry.py | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/secretsdump.py b/examples/secretsdump.py index 4e5333e1c..73c46cdc1 100755 --- a/examples/secretsdump.py +++ b/examples/secretsdump.py @@ -294,6 +294,7 @@ def dump(self): try: if self.__isRemote is True: SAMFileName = self.__remoteOps.saveSAM() + samFormat = "save" elif self.__samHive: SAMFileName = self.__samHive samFormat = "save" @@ -312,6 +313,7 @@ def dump(self): try: if self.__isRemote is True: SECURITYFileName = self.__remoteOps.saveSECURITY() + securityFormat = "save" elif self.__securityHive: SECURITYFileName = self.__securityHive securityFormat = "save" diff --git a/impacket/winregistry.py b/impacket/winregistry.py index 7b1750af9..af34b26bf 100644 --- a/impacket/winregistry.py +++ b/impacket/winregistry.py @@ -718,8 +718,8 @@ def __init__(self, hive, isRemote = False, hiveFormat = 'save'): self.__registryParser = exportRegistryParser(hive) def close(self): - if hasattr(self, 'fd'): - self.fd.close() + if hasattr(self.__registryParser, 'fd'): + self.__registryParser.fd.close() def __del__(self): self.close()