-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audio support #141
Draft
TahiTi
wants to merge
6
commits into
ThePorgs:dev
Choose a base branch
from
TahiTi:audio_support
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add audio support #141
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f42a48f
Add audio support
TahiTi e70d01e
Merge pull request #1 from ThePorgs/dev
TahiTi c3891fa
Fixed return type getPulseAudioSocketPath
TahiTi 4b6ad2e
Merge remote-tracking branch 'origin/audio_support' into audio_support
TahiTi 21ce11c
Changes by charlie
TahiTi 9841284
Fixed Dramelac comments
TahiTi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import io | ||
import os | ||
import shutil | ||
import subprocess | ||
import time | ||
TahiTi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
from pathlib import Path | ||
from typing import Optional | ||
|
||
from exegol.console.ExegolPrompt import Confirm | ||
from exegol.exceptions.ExegolExceptions import CancelOperation | ||
from exegol.utils.EnvInfo import EnvInfo | ||
from exegol.utils.ExeLog import logger, console | ||
|
||
|
||
class SoundUtils: | ||
"""This utility class allows determining if the current system supports the sound sharing | ||
from the information of the system.""" | ||
|
||
__distro_name = "" | ||
TahiTi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@classmethod | ||
def isPulseAudioAvailable(cls) -> bool: | ||
""" | ||
Check if the host OS has PulseAudio installed | ||
:return: bool | ||
""" | ||
assert os.getenv("XDG_RUNTIME_DIR") | ||
Dramelac marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return Path(f"{os.getenv('XDG_RUNTIME_DIR')}/pulse/native").exists() | ||
|
||
@classmethod | ||
def getPulseAudioSocketPath(cls) -> str: | ||
""" | ||
Get the host path of the Pulse Audio socket | ||
:return: | ||
""" | ||
# todo : find the path for windows/WSL | ||
assert os.getenv("XDG_RUNTIME_DIR") | ||
Dramelac marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return f"{os.getenv('XDG_RUNTIME_DIR')}/pulse/native" | ||
|
||
@classmethod | ||
def getPulseAudioCookiePath(cls) -> str: | ||
""" | ||
Get the host path of the Pulse Audio cookie | ||
:return: | ||
""" | ||
# todo : find the path for windows/WSL | ||
return f"{os.getenv('HOME')}/.config/pulse/cookie" | ||
#return Path().home() / "/.config/pulse/cookie" | ||
Dramelac marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why must_exist is set to False here ? Shouldn't be True instead ?
If the socket is not present, the feature cannot be activated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just below, he left a commented FIXME, indicating that a solution must be found here. In it's current state and in this context, the
addVolume
function raises an error whenmust_exist
is True 😉