UI Tweaks #19
UI Tweaks #19
Conversation
ISNIT0
commented
Jan 14, 2025
ISNIT0
commented
- Hide bottom nav by default (so the shutter button is clickable)
- Implement orientation responsiveness, so landscape photos can be taken
| viewModel.pauseRecording() | ||
| Icon( | ||
| imageVector = Icons.Filled.Pause, | ||
| contentDescription = "Pause Recording", |
There was a problem hiding this comment.
Thought: Is it worth starting localisation early? To save work adding it in later. Not suggesting in this PR tho.
There was a problem hiding this comment.
Agree, there are a bunch of things, including colors and magic numbers that also need to be moved. I'll do some research into localisation techniques in Android
| orientation in 330..360 || orientation in 0..30 -> 0 // Portrait | ||
| orientation in 60..120 -> -90 // Landscape (Right) | ||
| orientation in 150..210 -> 180 // Upside down | ||
| orientation in 240..300 -> 90 // Landscape (Left) |
There was a problem hiding this comment.
How does this behave when the phone is held between 300 & 330? Are these boundaries added to stop the phone flipping between orientations when the phone is held at weird angles?
There was a problem hiding this comment.
Yes, stops it from flickering when close to the edge
| WindowCompat.setDecorFitsSystemWindows(window, false) | ||
| window.statusBarColor = android.graphics.Color.TRANSPARENT | ||
| window.navigationBarColor = android.graphics.Color.TRANSPARENT | ||
|
|
||
| // Hide bottom navigation bar by default |
There was a problem hiding this comment.
as i see most apps don't hide the nav buttons
need to ask people who still use this type of navigation
There was a problem hiding this comment.
True, let's come back to this in future - keen to get this branch closed
ISNIT0
force-pushed
the
ISNIT0/ui-tweaks
branch
from
a50fc67 to
32597d1
Compare
ISNIT0
force-pushed
the
ISNIT0/ui-tweaks
branch
from
a2e1b6c to
32597d1
Compare
