Replace all item meta uses with data components #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant success and failure messages for item commands, consolidating them into single, streamlined messages. Added a new message, "nothing.changed," to handle cases where an action cannot modify anything. These changes improve clarity and maintain consistency across the localization files.
Replaced SkullMeta usage with DataComponentTypes.PROFILE for cleaner and more modern profile handling. Simplifies code and improves compatibility with the updated API.
Replaced direct ItemMeta manipulation with the ItemBuilder API to simplify and streamline lore modification operations. This improves code readability, reduces redundancy, and ensures better maintainability. Added checks to prevent unnecessary changes and updated corresponding methods accordingly.
Updated the rename logic to leverage DataComponentTypes for setting and comparing custom names. Improved message handling to provide clearer feedback and ensure proper success/failure status is returned.
Updated the repair logic to handle damage data components more effectively and return appropriate success/failure states. Adjusted 'repairAll' and individual item repair methods for better error handling and accuracy.
Replaced legacy item meta manipulation with the modern DataComponent API. This change ensures proper handling of unbreakable items and improves code readability and maintainability. Added checks for item compatibility with the required data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug where /repair made some items unstackable