Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main][560461](UserStory) prepare sdk 2.0.0 #69

Merged
merged 9 commits into from
Feb 13, 2024

Conversation

arvidfm
Copy link
Contributor

@arvidfm arvidfm commented Feb 12, 2024

  • general cleanup: reformat code, reorganise imports, add/improve type hints
    • these changes do not affect the execution of the code
  • add some more docstrings
    • and neither do these changes
  • add linting
    • prefer f-strings over format
    • always use class-based TypedDict definitions
    • use named constants instead of magic literals
    • use contextlib.suppress instead of try: ... except: pass
    • always specify argument name when passing a bool argument for better readability
    • various other minor things that Ruff complained about
  • add github workflow for pr checking
  • update some dependencies
    • grpcio and aiohttp for python 3.12 support, and add explicit dependency to typing-extensions which we were already using
  • bump SDK to version 2.0.0 due to breaking changes since the last release

The first two commits are the bulk of the changed lines, and since they don't actually affect the logic of the code in any way, I'd recommend filtering them out for an easier time reviewing

SuthyMike
SuthyMike previously approved these changes Feb 12, 2024
Copy link
Contributor

@SuthyMike SuthyMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable to me, looks nice and clean now :)

@flix-tools flix-tools bot added the WIP Not ready for review label Feb 13, 2024
Copy link

flix-tools bot commented Feb 13, 2024

Flix PR Util failed with message: "Unexpected error: Expecting value: line 1 column 1 (char 0)". Marking PR as WIP.

@arvidfm arvidfm changed the title [main][560461](UserStory) prepare sdk 2.0.0 [main][560461](UserStory) prepare sdk 2.0.0 Feb 13, 2024
@arvidfm arvidfm removed the WIP Not ready for review label Feb 13, 2024
Copy link
Contributor

@SuthyMike SuthyMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arvidfm arvidfm merged commit 14eeb14 into main Feb 13, 2024
10 checks passed
@arvidfm arvidfm deleted the 560461-dev-publish-python-sdk-for-flix-7 branch February 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants