-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main][560461](UserStory) prepare sdk 2.0.0 #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem reasonable to me, looks nice and clean now :)
Flix PR Util failed with message: "Unexpected error: Expecting value: line 1 column 1 (char 0)". Marking PR as WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
format
TypedDict
definitionscontextlib.suppress
instead oftry: ... except: pass
bool
argument for better readabilitygrpcio
andaiohttp
for python 3.12 support, and add explicit dependency totyping-extensions
which we were already usingThe first two commits are the bulk of the changed lines, and since they don't actually affect the logic of the code in any way, I'd recommend filtering them out for an easier time reviewing