Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/get best3 cities for buying soft drinks #83

Open
wants to merge 169 commits into
base: main
Choose a base branch
from
Open

Feature/get best3 cities for buying soft drinks #83

wants to merge 169 commits into from

Commits on Feb 7, 2023

  1. update gitignore to delete idea folder

    @AmeerAmjed
    AmeerAmjed committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    a49cf8e View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. add fake data

    @mosayed01
    mosayed01 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    46fe840 View commit details
    Browse the repository at this point in the history

  2. add test cases for cheapest banana price

    @mosayed01
    mosayed01 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c9362c5 View commit details
    Browse the repository at this point in the history

  3. add implementation for cheapest banana price

    @mosayed01
    mosayed01 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ccc6037 View commit details
    Browse the repository at this point in the history

  4. refactor: rename class cheapest banana price

    @mosayed01
    mosayed01 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    32c7ac1 View commit details
    Browse the repository at this point in the history

  5. add fake data

    Sajadio committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    52ac2e0 View commit details
    Browse the repository at this point in the history

  6. add test cases for matched city

    Sajadio committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0a93ebe View commit details
    Browse the repository at this point in the history

  7. add fake data

    @Ethaar7
    Ethaar7 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ac6bc35 View commit details
    Browse the repository at this point in the history

  8. add test cases

    @Ethaar7
    Ethaar7 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    4b9f576 View commit details
    Browse the repository at this point in the history

  9. update misspell countries names

    @TarekIdrees
    TarekIdrees committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    f31f887 View commit details
    Browse the repository at this point in the history

  10. first implementation of execute function

    @TarekIdrees
    TarekIdrees committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0f1eae0 View commit details
    Browse the repository at this point in the history

  11. add implementation test to actual code

    @Ethaar7
    Ethaar7 committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    4a52911 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. update version review

    @Abanoub-Nagy
    Abanoub-Nagy committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b61d6e1 View commit details
    Browse the repository at this point in the history

  2. add enum class in package

    @Ethaar7
    Ethaar7 committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d56567e View commit details
    Browse the repository at this point in the history

  3. apply the required changes in the review and improve Option to Bedroo… 

    …mOption
    @Ethaar7
    Ethaar7 committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    79c8049 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/feature/city_has_the_highest_dif… 

    …ferent' into feature/city_has_the_highest_different
    @Ethaar7
    Ethaar7 committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a732164 View commit details
    Browse the repository at this point in the history

  5. improve Option to BedroomOption as required changes in the review

    @Ethaar7
    Ethaar7 committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5234893 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/feature/city_has_the_highest_dif… 

    …ferent' into feature/city_has_the_highest_different
    @Ethaar7
    Ethaar7 committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5f5e975 View commit details
    Browse the repository at this point in the history

  7. update version review

    @Abanoub-Nagy
    Abanoub-Nagy committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3dcae3e View commit details
    Browse the repository at this point in the history

  8. change return type from empty string to null in case of the countries… 

    … doesn't exist
    Sajadio committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2d73e57 View commit details
    Browse the repository at this point in the history

  9. handle the case of countries names

    Sajadio committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    99622e5 View commit details
    Browse the repository at this point in the history

  10. add fake data and test cases

    @davidsamuelx
    davidsamuelx committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f3bc9cf View commit details
    Browse the repository at this point in the history

  11. update new version review

    @Abanoub-Nagy
    Abanoub-Nagy committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    db21962 View commit details
    Browse the repository at this point in the history

  12. improve code

    @AmeerAmjed
    AmeerAmjed committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    0517997 View commit details
    Browse the repository at this point in the history

  13. improve code

    @AmeerAmjed
    AmeerAmjed committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    24e0577 View commit details
    Browse the repository at this point in the history

  14. complete the logic of feature

    @TarekIdrees
    TarekIdrees committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9524918 View commit details
    Browse the repository at this point in the history

  15. improve fake data and test cases

    @davidsamuelx
    davidsamuelx committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a2ec718 View commit details
    Browse the repository at this point in the history

  16. add implementation for cheapest city internet

    @davidsamuelx
    davidsamuelx committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    80ebd39 View commit details
    Browse the repository at this point in the history

  17. add two test case

    @Abanoub-Nagy
    Abanoub-Nagy committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    56e0b5c View commit details
    Browse the repository at this point in the history

  18. improve logic of feature

    @Abanoub-Nagy
    Abanoub-Nagy committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d965a42 View commit details
    Browse the repository at this point in the history

  19. improve code to be readable

    @Ethaar7
    Ethaar7 committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9e7d460 View commit details
    Browse the repository at this point in the history

  20. add test case for best city interactor

    UG committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    683fc83 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. create GetCitiesAverageSalary class

    @Ashraf-El-Fallah
    Ashraf-El-Fallah committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    5c81c52 View commit details
    Browse the repository at this point in the history

  2. add test cases for average salaries

    @Ashraf-El-Fallah
    Ashraf-El-Fallah committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    ba43931 View commit details
    Browse the repository at this point in the history

  3. add fake data source

    @Ashraf-El-Fallah
    Ashraf-El-Fallah committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    4192cf2 View commit details
    Browse the repository at this point in the history

  4. make the code more readable by rename naming of variables and functions

    Sajadio committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    3f5bbf9 View commit details
    Browse the repository at this point in the history

  5. improve code to be readable

    @davidsamuelx
    davidsamuelx committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    3595ca7 View commit details
    Browse the repository at this point in the history

  6. rename test case and delete unnecessary dependency

    @davidsamuelx
    davidsamuelx committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    cb160ff View commit details
    Browse the repository at this point in the history

  7. complete tests

    UG committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    b1deb1c View commit details
    Browse the repository at this point in the history

  8. Delete FakeDataSource.kt

    @Ali873-debug
    Ali873-debug authored Feb 11, 2023
    Configuration menu
    Copy the full SHA
    3c61e63 View commit details
    Browse the repository at this point in the history

  9. complete Implementation

    Mohamed Emad committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    02d7c85 View commit details
    Browse the repository at this point in the history

  10. apply kotlin scope functions

    @TarekIdrees
    TarekIdrees committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    ef5e92e View commit details
    Browse the repository at this point in the history

  11. improve code

    Mohamed Emad committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    c091e0e View commit details
    Browse the repository at this point in the history

  12. improve code phase two

    Mohamed Emad committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    a8a8483 View commit details
    Browse the repository at this point in the history

  13. improve code to be short and readable

    @AmeerAmjed
    AmeerAmjed committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    95a401e View commit details
    Browse the repository at this point in the history

  14. initialize classes

    mustafa-sab3alarab committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    cfe53fc View commit details
    Browse the repository at this point in the history

  15. add fake data

    mustafa-sab3alarab committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    b2c1a41 View commit details
    Browse the repository at this point in the history

  16. add test cases for average fruits and vegetabls

    mustafa-sab3alarab committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    42873e8 View commit details
    Browse the repository at this point in the history

  17. complete execute function

    mustafa-sab3alarab committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    6606ac5 View commit details
    Browse the repository at this point in the history

  18. fix expected data in test class

    @Ali873-debug
    Ali873-debug committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    c7e1a13 View commit details
    Browse the repository at this point in the history

  19. add fake data

    @Ali873-debug
    Ali873-debug committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    477ba5d View commit details
    Browse the repository at this point in the history

  20. implement execute function for get cities average salary

    @Ali873-debug
    Ali873-debug committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    23b891d View commit details
    Browse the repository at this point in the history

  21. Merge remote-tracking branch 'origin/feature/cities_average_salary' i… 

    …nto feature/cities_average_salary

# Conflicts:
#	src/test/kotlin/datasource/FakeDataSource.kt
    @Ali873-debug
    Ali873-debug committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    de6a255 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. change toFormalCase function name to toChangeFormatCityName to be rea… 

    …dable
    @AmeerAmjed
    AmeerAmjed committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    8f979f1 View commit details
    Browse the repository at this point in the history

  2. improve execute function

    mustafa-sab3alarab committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    9456741 View commit details
    Browse the repository at this point in the history

  3. add new test case

    @Ali873-debug
    Ali873-debug committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    6e5c1cf View commit details
    Browse the repository at this point in the history

  4. improve code readability

    @TarekIdrees
    TarekIdrees committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    2d91220 View commit details
    Browse the repository at this point in the history

  5. change exception to illegal argument exception

    @Ali873-debug
    Ali873-debug committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    8dd1bd8 View commit details
    Browse the repository at this point in the history

  6. add new test case and improve logic code

    @davidsamuelx
    davidsamuelx committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    6c4934b View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/feature/cheapest_city_internet' … 

    …into feature/cheapest_city_internet

# Conflicts:
#	src/main/kotlin/interactor/GetCityHasCheapestInternetConnectionInteractor.kt
#	src/test/kotlin/interactor/GetCityHasCheapestInternetConnectionInteractorTest.kt
    @davidsamuelx
    davidsamuelx committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    69a568d View commit details
    Browse the repository at this point in the history

  8. improve code to be readable

    @Ethaar7
    Ethaar7 committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    d0f235f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/city_that_match_manager_expectations' into develop

    @AmeerAmjed
    AmeerAmjed committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    377bf3b View commit details
    Browse the repository at this point in the history

  10. add return city

    @abdellahtachouchout
    abdellahtachouchout committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    168feae View commit details
    Browse the repository at this point in the history

  11. clean up

    @AmeerAmjed
    AmeerAmjed committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    5d80830 View commit details
    Browse the repository at this point in the history

  12. frist commit

    @khaledeid1k
    khaledeid1k committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    830e5b2 View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/develop' into develop

    @khaledeid1k
    khaledeid1k committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    ba10673 View commit details
    Browse the repository at this point in the history

  14. TopTenCountriesTaxes class with initial test class.

    أســـــاور committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    21523e5 View commit details
    Browse the repository at this point in the history

  15. improve some code

    mustafa-sab3alarab committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    b098fa0 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'feature/average_fruits_vegetables' into develop 

    # Conflicts:
#	src/main/kotlin/Main.kt
    @AmeerAmjed
    AmeerAmjed committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    7111794 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Merge branch 'feature/city_has_the_highest_different' into develop 

    # Conflicts:
#	src/test/kotlin/dataSource/utils/FakeDataSource.kt
    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    bb9bc3e View commit details
    Browse the repository at this point in the history

  2. change handel fake data to create multi case in test case

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    b413df9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature/cheapest_city_internet

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    4f4d4e6 View commit details
    Browse the repository at this point in the history

  4. refactor fake data

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    da5b2d0 View commit details
    Browse the repository at this point in the history

  5. improve code and handel nullability salaries

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    6f62f45 View commit details
    Browse the repository at this point in the history

  6. TopTenCountriesTaxes class the null pointer exception solved.

    أســـــاور committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    eac887d View commit details
    Browse the repository at this point in the history

  7. improve code

    @khaledeid1k
    khaledeid1k committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    cdec55c View commit details
    Browse the repository at this point in the history

  8. add test without logic

    أســـــاور committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    84daf15 View commit details
    Browse the repository at this point in the history

  9. add logic

    أســـــاور committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    98fef9d View commit details
    Browse the repository at this point in the history

  10. create sub functions

    أســـــاور committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    2f6ae6d View commit details
    Browse the repository at this point in the history

  11. improve code and add comments to function

    @khaledeid1k
    khaledeid1k committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9f345e5 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/develop' into feature/cheapest_a… 

    …partments_with_count_of_years_to_buy

# Conflicts:
#	src/test/kotlin/interactor/GetCitiesNamesWithCheapestBananaPricesInteractorTest.kt
    @khaledeid1k
    khaledeid1k committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    1e97412 View commit details
    Browse the repository at this point in the history

  13. refactoring fake datasource

    @khaledeid1k
    khaledeid1k committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    67816fb View commit details
    Browse the repository at this point in the history

  14. Clean up

    @khaledeid1k
    khaledeid1k committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    d65bf8f View commit details
    Browse the repository at this point in the history

  15. Merge branch 'develop' into feature/cities_average_salary

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    d2398ea View commit details
    Browse the repository at this point in the history

  16. refactor fake data

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    4be3f93 View commit details
    Browse the repository at this point in the history

  17. add test case

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    e6e29f7 View commit details
    Browse the repository at this point in the history

  18. add fake data

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    f233eea View commit details
    Browse the repository at this point in the history

  19. delete file duplicated file

    @AmeerAmjed
    AmeerAmjed authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    345fca7 View commit details
    Browse the repository at this point in the history

  20. Merge remote-tracking branch 'origin/feature/best_fashion_shopping_ci… 

    …ties' into feature/best_fashion_shopping_cities
    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    d3c6774 View commit details
    Browse the repository at this point in the history

  21. implement feature get best cities for fashion shopping

    @AmeerAmjed
    AmeerAmjed committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    921a635 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Delete FakeDataSource.kt 

    delete duplicated file
    @AmeerAmjed
    AmeerAmjed authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    32407a0 View commit details
    Browse the repository at this point in the history

  2. Delete FakeDataSource.kt

    @AmeerAmjed
    AmeerAmjed authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a680681 View commit details
    Browse the repository at this point in the history

  3. improve fake data and edit test cases

    Mohamed Emad committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    984a72b View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/feature/best_city' into feature/… 

    …best_city

# Conflicts:
#	src/test/kotlin/interactor/GetBestCityForSavingMoneyInteractorTest.kt
    Mohamed Emad committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d7acdd4 View commit details
    Browse the repository at this point in the history

  5. improve fake data and edit test cases

    Mohamed Emad committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    dc3f883 View commit details
    Browse the repository at this point in the history

  6. improve fake data and edit test cases

    Mohamed Emad committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2778dcc View commit details
    Browse the repository at this point in the history

  7. fix issue with delete files from github

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2527fef View commit details
    Browse the repository at this point in the history

  8. Delete FakeDataSource.kt

    @AmeerAmjed
    AmeerAmjed authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    208e975 View commit details
    Browse the repository at this point in the history

  9. Delete FakeDataSource.kt

    @AmeerAmjed
    AmeerAmjed authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a5b9023 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feature/top_ten_countries_taxes' into develop

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    543fa8e View commit details
    Browse the repository at this point in the history

  11. fix merge and use fake data

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    85ede82 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'feature/best_fashion_shopping_cities' into develop 

    # Conflicts:
#	src/test/kotlin/data/FakeDataSource.kt
    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    fb40976 View commit details
    Browse the repository at this point in the history

  13. fix merge

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b3c9301 View commit details
    Browse the repository at this point in the history

  14. refactor code

    @davidsamuelx
    davidsamuelx committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e1ab1f3 View commit details
    Browse the repository at this point in the history

  15. add new test cases to fruit and vegetables

    mustafa-sab3alarab committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    64702d8 View commit details
    Browse the repository at this point in the history

  16. Merge pull request #17 from The-Cupcake-team/feature/add_new_case_to_… 

    …cheapest_city_internet

feature add new case to cheapest city internet
    @AmeerAmjed
    AmeerAmjed authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4cf27ff View commit details
    Browse the repository at this point in the history

  17. refactor code

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6fec065 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'develop' into feature/best_city_to_saving_money

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6bd4f4a View commit details
    Browse the repository at this point in the history

  19. improve code

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    afafb23 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'feature/add_new_test_case_to_fruits_vegetables' into de… 

    …velop
    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    7b88adc View commit details
    Browse the repository at this point in the history

  21. add helper to show result app

    @AmeerAmjed
    AmeerAmjed committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5940012 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Make functions have single responsibility

    @khaledeid1k
    khaledeid1k committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    619e6a5 View commit details
    Browse the repository at this point in the history

  2. change away get fake data

    @AmeerAmjed
    AmeerAmjed committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    1fdb013 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #19 from The-Cupcake-team/feature/refactor_handel_… 

    …fake_data

change away get fake data
    @AmeerAmjed
    AmeerAmjed authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    83cc2c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. fix(banana): change argument type

    @mosayed01
    mosayed01 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    fba621a View commit details
    Browse the repository at this point in the history

  2. exclude null fruits and vegetables prices

    mustafa-sab3alarab committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    f12e472 View commit details
    Browse the repository at this point in the history

  3. refactor fruits-vegetables fake data

    mustafa-sab3alarab committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e8cd71f View commit details
    Browse the repository at this point in the history

  4. improve test cases of fuits and vegetables

    mustafa-sab3alarab committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    cadeb99 View commit details
    Browse the repository at this point in the history

  5. edit names of functions, calculate the ratio and exclude null fruit v… 

    …egetable price and null salaries
    mustafa-sab3alarab committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    5b8d7f2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into fix/GetTopTenCitiesHasCheapestPriceOfApar… 

    …tmentsAndYearInteractor
    @khaledeid1k
    khaledeid1k committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    03deb05 View commit details
    Browse the repository at this point in the history

  7. fix best city for saving money interactor

    Mohamed Emad committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e5d67dd View commit details
    Browse the repository at this point in the history

  8. refactor(banana_test): change way of naming functions

    @mosayed01
    mosayed01 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    6e9fe27 View commit details
    Browse the repository at this point in the history

  9. fix(costlier): change logic

    @Ethaar7
    Ethaar7 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    cdf390d View commit details
    Browse the repository at this point in the history

  10. fix(costlier): change test

    @Ethaar7
    Ethaar7 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    d65a8cf View commit details
    Browse the repository at this point in the history

  11. fix(costlier): refactor fake data

    @Ethaar7
    Ethaar7 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    10fb665 View commit details
    Browse the repository at this point in the history

  12. fix(internet_test): refactor test cases

    @davidsamuelx
    davidsamuelx committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    4d32831 View commit details
    Browse the repository at this point in the history

  13. fix(internet): change logic code

    @davidsamuelx
    davidsamuelx committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    d356405 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. refactor(internet_test): change test case name

    @davidsamuelx
    davidsamuelx committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    49beb52 View commit details
    Browse the repository at this point in the history

  2. refactor(banana_test): change fake data to objects

    @mosayed01
    mosayed01 committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    4d58b12 View commit details
    Browse the repository at this point in the history

  3. refactor(banana): change empty cases to throw

    @mosayed01
    mosayed01 committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    e336412 View commit details
    Browse the repository at this point in the history

  4. fix(internet): change exception

    @davidsamuelx
    davidsamuelx committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    23c73a5 View commit details
    Browse the repository at this point in the history

  5. test(internet): change exception type

    @davidsamuelx
    davidsamuelx committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    e5ce886 View commit details
    Browse the repository at this point in the history

  6. test(internet): add enhancement to test cases

    @davidsamuelx
    davidsamuelx committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a98dea0 View commit details
    Browse the repository at this point in the history

  7. refactor(city highest difference test): change style of naming function

    @Ethaar7
    Ethaar7 committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    05af75d View commit details
    Browse the repository at this point in the history

  8. fix: change logic

    @khaledeid1k
    khaledeid1k committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c9076d7 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #20 from The-Cupcake-team/fix/cheapest_banana_para… 

    …meter_type

change argument type from string to city
    @AmeerAmjed
    AmeerAmjed authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    0c21ea6 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. feat: add interactor for cheapest tennis price

    @mosayed01
    mosayed01 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    168b037 View commit details
    Browse the repository at this point in the history

  2. test: add test cases for cheapest tennis price

    @mosayed01
    mosayed01 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    1e4ff11 View commit details
    Browse the repository at this point in the history

  3. feat: add implementation for cheapest tennis weekend

    @mosayed01
    mosayed01 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    2d39642 View commit details
    Browse the repository at this point in the history

  4. change comments in fruit and vegetables class test

    Mustafa Sabe Alarab committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    43cdafc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into fix/fruits_not_exclude_nulls

    Mustafa Sabe Alarab committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    f41bda5 View commit details
    Browse the repository at this point in the history

  6. take how many cities the user need it

    Mustafa Sabe Alarab committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    928a169 View commit details
    Browse the repository at this point in the history

  7. add test case for fruit and vegetable when data source is empty

    Mustafa Sabe Alarab committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    fcef0b8 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #21 from The-Cupcake-team/fix/fruits_not_exclude_n… 

    …ulls

Check nullability of fruit and vegetables
    @AmeerAmjed
    AmeerAmjed authored Feb 19, 2023
    Configuration menu
    Copy the full SHA
    804e69b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'fix/refactor_feature‏_city_has_the_highest_difference' … 

    …into develop
    @AmeerAmjed
    AmeerAmjed committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    c273e92 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. add the tests of the new feature

    Mohamed Emad committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ef57489 View commit details
    Browse the repository at this point in the history

  2. improve test cases

    Mohamed Emad committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    78fd058 View commit details
    Browse the repository at this point in the history

  3. complete the feature

    Mohamed Emad committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6028955 View commit details
    Browse the repository at this point in the history

  4. test(internet): refactor fake data

    @davidsamuelx
    davidsamuelx committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    db9acbd View commit details
    Browse the repository at this point in the history

  5. test(internet): refactor test cases

    @davidsamuelx
    davidsamuelx committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    8ac4e97 View commit details
    Browse the repository at this point in the history

  6. test: add val to expected values

    @mosayed01
    mosayed01 committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    a9c719a View commit details
    Browse the repository at this point in the history

  7. test: edite val name

    @mosayed01
    mosayed01 committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    d4fcbee View commit details
    Browse the repository at this point in the history

  8. fix: change message of throw exception

    @khaledeid1k
    khaledeid1k committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ca2da37 View commit details
    Browse the repository at this point in the history

  9. test: change style of naming testing functions

    @davidsamuelx
    davidsamuelx committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    844be77 View commit details
    Browse the repository at this point in the history

  10. refactor: change message of exception

    @davidsamuelx
    davidsamuelx committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    78a58df View commit details
    Browse the repository at this point in the history

  11. fix: change class to object

    @khaledeid1k
    khaledeid1k committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    c5a0133 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #24 from The-Cupcake-team/fix/refactor_feature_cit… 

    …y_has_cheapest_internet

Fix/refactor feature city has cheapest internet
    @AmeerAmjed
    AmeerAmjed authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    82ae43e View commit details
    Browse the repository at this point in the history

  13. Merge branch 'fix/top_cities_has_cheapest_price_of_apartments_and_yea… 

    …r' into develop
    @AmeerAmjed
    AmeerAmjed committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    f7b67d2 View commit details
    Browse the repository at this point in the history

  14. Merge pull request #26 from The-Cupcake-team/feature/tennis_weekend 

    A tennis lover man who wants to spend his weekend in cheapest city in the world for tennis so help him to achieve his goal (new feature ).
    @AmeerAmjed
    AmeerAmjed authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    0926c52 View commit details
    Browse the repository at this point in the history

  15. fix: rename execute function to invoke

    Mustafa Sabe Alarab committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4386f22 View commit details
    Browse the repository at this point in the history

  16. test: change function to invoke

    @davidsamuelx
    davidsamuelx committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    296717c View commit details
    Browse the repository at this point in the history

  17. refactor: change function to invoke in logic

    @davidsamuelx
    davidsamuelx committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    71f4621 View commit details
    Browse the repository at this point in the history

  18. test: refactor test cases

    @davidsamuelx
    davidsamuelx committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    cd2ac76 View commit details
    Browse the repository at this point in the history

  19. Merge pull request #32 from The-Cupcake-team/fix/refactor_feature_cit… 

    …y_has_cheapest_internet

change function to invoke.
    @mosayed01
    mosayed01 authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    1f98d0b View commit details
    Browse the repository at this point in the history

  20. Merge pull request #31 from The-Cupcake-team/fix/fruits_not_exclude_n… 

    …ulls

change function to invoke
    @AmeerAmjed
    AmeerAmjed authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    c110948 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'develop' into feature/get_best_cities_for_buying_soft_d… 

    …rinks
    Mohamed Emad committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    bdf71a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. transform fake data class to singleton

    Mohamed Emad committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    6cd4533 View commit details
    Browse the repository at this point in the history

  2. improve test cases

    Mohamed Emad committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    6fca653 View commit details
    Browse the repository at this point in the history

  3. improve readability

    Mohamed Emad committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    d8b0b69 View commit details
    Browse the repository at this point in the history