Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/get best3 cities for buying soft drinks #83

Open
wants to merge 169 commits into
base: main
Choose a base branch
from
Open

Feature/get best3 cities for buying soft drinks #83

wants to merge 169 commits into from

Conversation

MohamedEmad7299
Copy link

No description provided.

AmeerAmjed and others added 30 commits February 7, 2023 08:54
@AmeerAmjed
update gitignore to delete idea folder
a49cf8e
@mosayed01
add fake data
46fe840
@mosayed01
add test cases for cheapest banana price
c9362c5
@mosayed01
add implementation for cheapest banana price
ccc6037
@mosayed01
refactor: rename class cheapest banana price
32c7ac1
add fake data
52ac2e0
add test cases for matched city
0a93ebe
@Ethaar7
add fake data
ac6bc35
@Ethaar7
add test cases
4b9f576
@TarekIdrees
update misspell countries names
f31f887
@TarekIdrees
first implementation of execute function
0f1eae0
@Ethaar7
add implementation test to actual code
4a52911
@Abanoub-Nagy
update version review
b61d6e1
@Ethaar7
add enum class in package
d56567e
@Ethaar7
apply the required changes in the review and improve Option to Bedroo…
79c8049 
…mOption
@Ethaar7
Merge remote-tracking branch 'origin/feature/city_has_the_highest_dif…
a732164 
…ferent' into feature/city_has_the_highest_different
@Ethaar7
improve Option to BedroomOption as required changes in the review
5234893
@Ethaar7
Merge remote-tracking branch 'origin/feature/city_has_the_highest_dif…
5f5e975 
…ferent' into feature/city_has_the_highest_different
@Abanoub-Nagy
update version review
3dcae3e
change return type from empty string to null in case of the countries…
2d73e57 
… doesn't exist
handle the case of countries names
99622e5
@davidsamuelx
add fake data and test cases
f3bc9cf
@Abanoub-Nagy
update new version review
db21962
@AmeerAmjed
improve code
0517997
@AmeerAmjed
improve code
24e0577
@TarekIdrees
complete the logic of feature
9524918
@davidsamuelx
improve fake data and test cases
a2ec718
@davidsamuelx
add implementation for cheapest city internet
80ebd39
@Abanoub-Nagy
add two test case
56e0b5c
@Abanoub-Nagy
improve logic of feature
d965a42
Mustafa Sabe Alarab and others added 29 commits February 19, 2023 15:15
Merge branch 'develop' into fix/fruits_not_exclude_nulls
f41bda5
take how many cities the user need it
928a169
add test case for fruit and vegetable when data source is empty
fcef0b8
@AmeerAmjed
Merge pull request #21 from The-Cupcake-team/fix/fruits_not_exclude_n…
804e69b 
…ulls

Check nullability of fruit and vegetables
@AmeerAmjed
Merge branch 'fix/refactor_feature‏_city_has_the_highest_difference' …
c273e92 
…into develop
add the tests of the new feature
ef57489
improve test cases
78fd058
complete the feature
6028955
@davidsamuelx
test(internet): refactor fake data
db9acbd
@davidsamuelx
test(internet): refactor test cases
8ac4e97
@mosayed01
test: add val to expected values
a9c719a
@mosayed01
test: edite val name
d4fcbee
@khaledeid1k
fix: change message of throw exception
ca2da37
@davidsamuelx
test: change style of naming testing functions
844be77
@davidsamuelx
refactor: change message of exception
78a58df
@khaledeid1k
fix: change class to object
c5a0133
@AmeerAmjed
Merge pull request #24 from The-Cupcake-team/fix/refactor_feature_cit…
82ae43e 
…y_has_cheapest_internet

Fix/refactor feature city has cheapest internet
@AmeerAmjed
Merge branch 'fix/top_cities_has_cheapest_price_of_apartments_and_yea…
f7b67d2 
…r' into develop
@AmeerAmjed
Merge pull request #26 from The-Cupcake-team/feature/tennis_weekend
0926c52 
A tennis lover man who wants to spend his weekend in cheapest city in the world for tennis so help him to achieve his goal (new feature ).
fix: rename execute function to invoke
4386f22
@davidsamuelx
test: change function to invoke
296717c
@davidsamuelx
refactor: change function to invoke in logic
71f4621
@davidsamuelx
test: refactor test cases
cd2ac76
@mosayed01
Merge pull request #32 from The-Cupcake-team/fix/refactor_feature_cit…
1f98d0b 
…y_has_cheapest_internet

change function to invoke.
@AmeerAmjed
Merge pull request #31 from The-Cupcake-team/fix/fruits_not_exclude_n…
c110948 
…ulls

change function to invoke
Merge branch 'develop' into feature/get_best_cities_for_buying_soft_d…
bdf71a6 
…rinks
transform fake data class to singleton
6cd4533
improve test cases
6fca653
improve readability
d8b0b69
@AmeerAmjed AmeerAmjed deleted the feature/GetBest3CitiesForBuyingSoftDrinks branch February 21, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.