Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/get cheapest basic prices #77

Open
wants to merge 330 commits into
base: main
Choose a base branch
from
Open

Feature/get cheapest basic prices #77

wants to merge 330 commits into from

Conversation

NargesNagy
Copy link

No description provided.

Mohamed Elgohary and others added 30 commits February 12, 2023 13:39
Merge branch 'feature/get-salary-averages-for-cities' of https://gith…
a36732f 
…ub.com/AzizaHelmy/cost-of-living into feature/get-salary-averages-for-cities
@RehabFakhry
call execute function from class getSalaryAverageForCitiesInCountryIn…
e4a3be9 
…teractor
Merge branch 'feature/get-salary-averages-for-cities' of https://gith…
d6ae000 
…ub.com/AzizaHelmy/cost-of-living into feature/get-salary-averages-for-cities
@ahmednasserzaza
clean unnecessary named data type
d4b2d02
@AzizaHelmy
add GetSuitableCityMoreSavingPerMonthInteractor class
805ff2a
@AzizaHelmy
add the test class
1dc79bc
@AzizaHelmy
add FakeData class for testing
d6ae9de
correct warnings messages in test class
8d2b391
@SaraSallah
add second test case for input full-time-salary-equal-zero
f7c4abe
@SaraSallah
add third test case for input negative-full-time-salary-
98f6723
@AzizaHelmy
add initial commit for first test case
233bedc
@AzizaHelmy
add the function for first test case
6e1dd90
@ZeinabAbdien00
add top ten class and test class
adf64e9
@ZeinabAbdien00
add top ten class and test class
50643f1
@ZeinabAbdien00
test size of list
1819d69
@AzizaHelmy
add test cases for excludeNullSalaries function
6e78f42
@ahmednasserzaza
add new test case in GetCheapestBananaCitiesNamesInteractorTest
b2b32ca
@AzizaHelmy
add test cases for excludeNullApartment3BedroomsInCityCenter function
4ed8dd7
@ahmednasserzaza
create Top10CitiesFruitsAndVegetablesLowestCostInteractor with a func…
19468b9 
…tion execute not implemented yet
@AzizaHelmy
add test case for excludeNullFoodies function
9197c4e
@ahmednasserzaza
edit parameter in function execute which we may use in testing
c93e4ed
@AzizaHelmy
add test cases for excludeNullFoodies function
b75f1ef
@ZeinabAbdien00
test null exception
25566af
@ZeinabAbdien00
null exception test
147c329
@ZeinabAbdien00
execute logic
65820d6
@AzizaHelmy
add isSuitableApartment function
3cba05f
@ahmednasserzaza
create FakeData which we would use in testing
24d5a8a
@ahmednasserzaza
rename Top10CitiesFruitsAndVegetablesLowestCostInteractor to GetTop10…
b4b88b5 
…CitiesFruitsAndVegetablesLowestCostInteractor
@ahmednasserzaza
create test for GetTop10CitiesFruitsAndVegetablesLowestCostInteractor
e26e9e9
@AzizaHelmy
add test cases to isSuitableApartment function
b83b97a
Mohamed Elgohary and others added 30 commits February 18, 2023 22:44
edit function execute in SearchCheapestCarInCountryInteractor
9a5dbd8
@AzizaHelmy
Merge remote-tracking branch 'origin/develop' into develop
e9069ef
@ahmednasserzaza
use function getAverageFruitAndVegetablesPrices exists in model
4b85d86
@ahmednasserzaza
update test cases in GetTopCitiesFruitsAndVegetablesLowestCostInterac…
a4f8da6 
…torTest
@AzizaHelmy
Merge remote-tracking branch 'origin/fix/use-functions-in-models' int…
8916ea0 
…o develop
edit function GetSalaryAverageForCitiesInCountryInteractor
1cb007c
edit function GetSalaryAverageForCitiesInCountryInteractor
ab31b7a
Merge remote-tracking branch 'origin/develop' into develop
3242620
@AzizaHelmy
enhance the code
1fa94e4
@AzizaHelmy
Merge remote-tracking branch 'origin/develop' into develop
56a50c9
enhance code
7d9e656
Merge remote-tracking branch 'origin/develop' into develop
e9430bc
@AzizaHelmy
rename the name of test function
e90f233
@AzizaHelmy
Merge remote-tracking branch 'origin/develop' into develop
f94b41c
@AzizaHelmy
clean up the code
d164217
@mahmmedn19
update the names of some test cases to make them more descriptive, an…
81b4e90 
…d added comments to all tests to improve readability
@ahmednasserzaza
update test cases in GetCityHasLowestYearsToBuyApartmentInteractorTest
3d1bb35
@ahmednasserzaza
Merge remote-tracking branch 'origin/develop' into develop
5670b1f
@Mohamedragabali
edit name fun in test cases
e19fb1d
@Mohamedragabali
edit fun to scope in GetTopCitiesNameHasSuitableClothesPricesInteractor
6dac040
@Mohamedragabali
Merge remote-tracking branch 'origin/develop' into develop
56670ec
@ahmednasserzaza
update test cases in GetCityHasCheapestInternetConnectionInteractorTest
b25bf88
@ahmednasserzaza
Merge remote-tracking branch 'origin/develop' into develop
5c95596
@ahmednasserzaza
update test cases in GetTopCitiesNameHasSuitableClothesPricesInteract…
7926710 
…orTest
@NargesNagy
add function to MockCityEntity class
223ce04
@NargesNagy
add test cases for execludeNullSalaryAndQualityDataAndOtherBaicPrices…
890f2d7 
… function
@NargesNagy
add implemintation for execludeNullSalaryAndQualityDataAndOtherBaicPr…
fe73274 
…ices function
@NargesNagy
add test cases for execute function
632c522
@NargesNagy
Revert "add test cases for execute function"
127f1fd 
This reverts commit 632c522.
@NargesNagy
add implementation for execute function
00566ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@NargesNagy @RehabFakhry @ahmednasserzaza @AzizaHelmy @SaraSallah @ZeinabAbdien00 @mahmmedn19 @Mohamedragabali @M7mdSh3banX @Rehammashal7