Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix feature reorderCitiesByCheapestBananaPrices #66

Open
wants to merge 148 commits into
base: main
Choose a base branch
from
Open

fix feature reorderCitiesByCheapestBananaPrices #66

wants to merge 148 commits into from

Conversation

OussamaZara
Copy link

No description provided.

youssef638 and others added 30 commits February 11, 2023 15:28
@youssef638
init suitable saving city class and test
47d3fd7
@MohammedSaad199517
create first unit test
f2bbaea
@MohammedSaad199517
create first unit test
105394d
@kamelkiko
active test package
d30b0ae
@yassenRamadan1
Merge pull request #3 from yassenRamadan1/feature/fake-data
9bd9ccb 
active test package
@youssef638
fix test init place
dc60e5c
@youssef638
init the empty functions and there tests
6d3714b
@youssef638
add new data class and update CsvDataSource with new parseLine
0f87681
@MohammedSaad199517
add test for lowercase entry name
15b565b
@youssef638
add test cases for calculateFamilyBudget
4bd401e
@youssef638
implement calculateFamilyBudget
b609a7c
@youssef638
fix test
1fd0124
@youssef638
add test cases for calculateFoodCost
b9802b7
@yassenRamadan1
add test cases
29236f3
@youssef638
implement calculateFoodCost and fix test
c0a6d72
@youssef638
fix bugs
238896a
@youssef638
remove calculateFoodCost -ve test
5dcd275
@youssef638
add test cases for calculateCitySavings
fa3e874
@youssef638
implement calculateCitySavings function and fix test bugs
cf317f3
@youssef638
add excludeNullSalaries test cases
175217d
@MohammedSaad199517
add two test for upper and mix case entry name
b8c17f8
@youssef638
implement the null check function fix bugs
9ac4ed1
@yassenRamadan1
start implementation of function
3229c33
@Mujtba99
prepare interactor
b48ad11
@OussamaZara
add a function to reorder cities by cheapest banana prices
84508a0
@MohammedSaad199517
update unit test to avoid low quality data
82fa508
@MohammedSaad199517
add test for wrong country name
79bef98
@MohammedSaad199517
add another test for wrong country name
44b1cd9
@MohammedSaad199517
create execute function that return finally result
b69086b
@youssef638
fix calculateCitySavings test and excludeNullSalaries test
5bfd6d2
yassenRamadan1 and others added 30 commits February 18, 2023 22:12
@yassenRamadan1
Merge pull request #21 from yassenRamadan1/fix/highest_coke_price_of_…
270ebbd 
…ten_countries

fix the logic and test cases
@MohammedSaad199517
change code on execution function in interactor class and unit test f…
146dbdf 
…unction
@yassenRamadan1
Merge pull request #25 from yassenRamadan1/fix/get-the-average-salary…
1a2fd88 
…-for-each-cityIn-the-country

change code on execution function in interactor class and unit test f…
@ahmedfaris2023
fix the logic and test
4bd407d
@yassenRamadan1
Merge pull request #26 from yassenRamadan1/_fix-feature/city-highest-…
c8f4313 
…different-between-apartment-citycenter-and-outsidecitycenter_

fix the logic and test
@youssef638
change GetMostSuitableSavingCityInteractor file to class
b2219a3
@MohammedSaad199517
add test for null salary average
f08797a
@ahmedfaris2023
fix the test
47e9747
@yassenRamadan1
Merge pull request #27 from yassenRamadan1/fix/get_suitable_saving_city
78ab1ed 
change GetMostSuitableSavingCityInteractor file to class
@yassenRamadan1
change some data in fake data
9849fdc
@yassenRamadan1
Merge remote-tracking branch 'origin/develop' into fix/feature-get--a…
fb6e2a0 
…partment-faster
@yassenRamadan1
change some comments
34e1fc4
@ahmedfaris2023
fix two test
4ade9ff
@ahmedfaris2023
fix two test
fefb045
@ahmedfaris2023
Merge remote-tracking branch 'origin/_fix-feature/city-highest-differ…
3ff1fdd 
…ent-between-apartment-citycenter-and-outsidecitycenter_' into _fix-feature/city-highest-different-between-apartment-citycenter-and-outsidecitycenter_
@yassenRamadan1
Merge pull request #28 from yassenRamadan1/_fix-feature/city-highest-…
ca7d2ff 
…different-between-apartment-citycenter-and-outsidecitycenter_

Fix feature/city highest different between apartment citycenter and outsidecitycenter
@MohammedSaad199517
update comment and message in throw exception
4ceabc6
@yassenRamadan1
Merge pull request #29 from yassenRamadan1/fix/get-the-average-salary…
a8e75eb 
…-for-each-cityIn-the-country

Fix/get the average salary for each city in the country
@Mujtba99
fix GetTopCitiesFruitsAndVegetablesLowestCostInteractor test class
d1542d9
@Mujtba99
fix GetTopCitiesFruitsAndVegetablesLowestCostInteractor class
a4bb99d
@azoz2134
fix test
c989002
@azoz2134
fix interactor
e0335b3
@yassenRamadan1
Merge pull request #31 from yassenRamadan1/fix/find-city-with-meal-pr…
6b2e416 
…ice-beween-suggestion

Fix/find city with meal price beween suggestion
@yassenRamadan1
Merge pull request #30 from yassenRamadan1/fix/get-lowest-fruit-and-v…
9f60536 
…agetables-prices-cities-names-interactor

Fix/get lowest fruit and vagetables prices cities names interactor
@hsalim78
fix the task to get top five cities for fashion
01c1d68
@yassenRamadan1
Merge pull request #32 from yassenRamadan1/fix/top-five-famous-brands…
7cc8c20 
…-suitable-prices-citiesfix/top-five-famous-brands-suitable-prices-cities

Fix/top five famous brands suitable prices citiesfix
@yassenRamadan1
finish the fix
2d7f23f
@yassenRamadan1
push all changes to main
238219d
@yassenRamadan1
fix conflict
78dd55c
@yassenRamadan1
Merge pull request #33 from yassenRamadan1/develop
ccb0592 
Develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@OussamaZara @youssef638 @MohammedSaad199517 @kamelkiko @yassenRamadan1 @Mujtba99 @mustafayassi @ahmedfaris2023 @azoz2134 @hsalim78