Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/fashion-cities #60

Open
wants to merge 84 commits into
base: develop
Choose a base branch
from
Open

feature/fashion-cities #60

wants to merge 84 commits into from

Conversation

Belal-Alkhatib
Copy link

add more test function

ahmdghannam and others added 30 commits February 8, 2023 10:59
@ahmdghannam
create test directory
8b0951d
@ahmdghannam
Merge pull request #3 from ahmdghannam/feature/CityHasCheapestInternet
5f366a2 
create test directory
@QasemFJber
build one
3a5c0f1
@MahmoudRH
update .gitignore
39eb7f3
@ahmdghannam
update .gitignore file
3bc2601
@ahmdghannam
create csvFiles folder and put all csv files init
76812eb
@ahmdghannam
CsvDataSource class can have different file path
b69468c
@ahmdghannam
add 7 test cases to GetCityHasCheapestInternetConnectionInteractorTes…
0e042dc 
…t , zero tests passed
@ahmdghannam
add the code to execute function and 7 of 7 test cases pass
220db00
@ahmdghannam
Merge pull request #7 from ahmdghannam/feature/getCityHasCheapestInte…
37165ef 
…rnetConnection

Feature/get city has cheapest internet connection
@ahmdghannam
ignored local.properties file and . idea files
8160d5f
@ahmdghannam
Merge pull request #8 from ahmdghannam/ideaFilesIgnoring
ea4ee78 
ignored local.properties file and . idea files
@MahmoudRH
init GetCityThatHasAverageMealsPricesIntractor
77cbe38
@mohammed-akkad
add all cases testing and initial function
719b419
@mohammed-akkad
improve function execute
9acd54a
@mohammed-akkad
correct the cases and optimize the performance of the function execute
69e5f9c
@mohammed-akkad
improve performance function execute
0d1c8bd
@loay-al-shobaki
added new functions
57b768f
@loay-al-shobaki
Merge remote-tracking branch 'origin/develop' into feature/CitySaving…
50a9efd 
…Month

# Conflicts:
#	src/main/kotlin/Main.kt
@mohammed-akkad
improve performance function testing case and find city have more sav…
7e900d0 
…ings per month.
@loay-al-shobaki
added new cases and test file data
b2a6de8
@loay-al-shobaki
update file average salary
c67d0e0
@loay-al-shobaki
update file average salary
6f3ae32
@mohammed-akkad
improve code style
1f78eb8
@Agha826
add class testing and four function test
13f8fb6
@mohammed-akkad
improve execute function
f486a58
@Agha826
add mockk in build.gradle.kts file
31a5a8e
@loay-al-shobaki
add new test case and test file
9ebb448
@mohammed-akkad
improve code style
75aafe9
@loay-al-shobaki
Merge remote-tracking branch 'origin/feature/get_city_saving_month' i…
aa18c46 
…nto feature/get_city_saving_month

# Conflicts:
#	src/main/kotlin/interactor/GetCityHasMoreSavingsPerMonthInteractor.kt
MahmoudRH and others added 30 commits February 13, 2023 13:48
@MahmoudRH
implement feature interactor functions
5460bf2
@MahmoudRH
invoke interactor in main function
4e795df
@loay-al-shobaki
add test cases
56e838b
@ahmdghannam
Merge pull request #12 from ahmdghannam/feature/get_top_10_countries_…
7551dbf 
…enforce_high_taxes_on_carbonated_drink

Feature/get top 10 countries enforce high taxes on carbonated drink
@mohammed-akkad
improve code testing style
b2a4a74
@mohammed-akkad
improve code style
07e7498
@ahmdghannam
Merge pull request #14 from ahmdghannam/feature/hate_the_crowd_and_lo…
b162314 
…ve_the_nature

Feature/hate the crowd and love the nature
@ahmdghannam
Merge pull request #15 from ahmdghannam/feature/get-salaries-of-count…
59216e7 
…ry-cities

Feature/get salaries of country cities
@ahmdghannam
call the interactors from main
96f8276
@Garfend
Added all test cases and fake data
e81f016
@mohammed-akkad
delete unused csv files
2c3ec97
@mohammed-akkad
Merge branch 'develop' into feature/get_city_saving_month
03f51de
@ahmdghannam
Merge pull request #16 from ahmdghannam/feature/get_city_saving_month
6e458db 
Feature/get city saving month
@Garfend
Added Interactor function
3836fe0
@ahmdghannam @MohmadAlastal
Write the Test of Find_CityTest
fa07ccf
@MohmadAlastal
Wirte Test to Find_CityTest
a8520d6
@MohmadAlastal
Wirte The Function
d850d52
@MohmadAlastal
Merge remote-tracking branch 'origin/feature/find_city_with_highest_a…
4f70195 
…ppartments_rent_' into feature/find_city_with_highest_appartments_rent_
@MohmadAlastal
Write The Function
c1f8d52
@MohmadAlastal
Merge remote-tracking branch 'origin/feature/find_city_with_highest_a…
d2c211a 
…ppartments_rent_' into feature/find_city_with_highest_appartments_rent_
@Garfend
Fixed null salaries and fruit and vegetables prices test cases, added…
3d7d23c 
… more comments
@ahmdghannam
Merge branch 'develop' into feature/avgFruitNVeggie
1aba23a
@ahmdghannam @MahmoudRH
Update src/main/kotlin/interactor/GetAvgFruitNVeggieInteractor.kt
776685a 
Co-authored-by: Mahmoud Habib <mhabeeb5@students.iugaza.edu.ps>
@ahmdghannam
Merge pull request #17 from ahmdghannam/feature/find_city_with_highes…
42def55 
…t_appartments_rent_

Feature/find city with highest appartments rent
@ahmdghannam
Merge pull request #18 from ahmdghannam/feature/avgFruitNVeggie
209557a 
Feature/avg fruit n veggie
@ahmdghannam
update main class and invoke execute functions for each task
4f607e6
@ahmdghannam
solve a problem in a test
79d1679
@Belal-Alkhatib
add my fix code for GetTopFiveFashionCitiesInteractor file
26c0763
@Belal-Alkhatib
add more test function
7bf6c71
@Belal-Alkhatib
edit my execute function
55de739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.