Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing missing var #89

Merged
merged 2 commits into from
Dec 19, 2024
Merged

removing missing var #89

merged 2 commits into from
Dec 19, 2024

Conversation

coltleese17
Copy link
Collaborator

@coltleese17 coltleese17 commented Dec 18, 2024

Fix error with mn_prev_year_state_refund on line 28 of fiscalsim_us/variables/gov/states/mn/tax/income/mn_taxable_income.py. @rickecon

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (a4c4135) to head (e8c10b7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files        1954     1954           
  Lines       28732    28732           
  Branches      150      150           
=======================================
  Hits        28190    28190           
  Misses        508      508           
  Partials       34       34           
Flag Coverage Δ
unittests 98.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickecon
Copy link
Collaborator

@coltleese17. Good catch. Rather than delete mn_prev_year_state_refund in fiscalsim_us/variables/gov/states/mn/tax/income/mn_taxable_income.py, just fix the typo in the class definition of the variable fiscalsim_us/variables/gov/states/mn/tax/income/subtractions/mn_prev_year_state_refund.py. It is currently incorrectly spelled mmn_prev_year_state_refund on line 4. Should be mn_prev_year_state_refund.

@rickecon
Copy link
Collaborator

@coltleese17. Looks great. Nice catch.

@rickecon rickecon merged commit 0a2df88 into main Dec 19, 2024
17 checks passed
@rickecon rickecon mentioned this pull request Dec 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants