-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed circularity issues for CO and MO #67
Conversation
Merging
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 98.37% 98.37% -0.01%
==========================================
Files 1773 1773
Lines 26463 26462 -1
Branches 176 176
==========================================
- Hits 26034 26033 -1
Misses 398 398
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@mitchellpound. This looks great. I ran all the test locally on my machine as well. Everything passes. I submitted a PR to your branch that updates the version in |
@rickecon Thanks! Just merged in your PR with the version and change log stuff. |
@mitchellpound. Thanks Mitch. Looks great. Merging. |
make format
andmake documentation
has been run.Bug fix
This is to fix the circularity errors mentioned in issue #64
What this fixes and how it's fixed
The main problem was from the
state_income_tax
variable.CO fixes:
state_income_tax
for variables that reference last year's .MO fixes:
state_income_tax
forprior_year_state_income_tax_paid
to break the circularity.For both CO and MO I updated the baseline unit test variables to reflect those used in formula definitions.