Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed circularity issues for CO and MO #67

Merged
merged 12 commits into from
Oct 24, 2023

Conversation

mitchellpound
Copy link
Contributor

@mitchellpound mitchellpound commented Oct 24, 2023

  • make format and make documentation has been run.

Bug fix

This is to fix the circularity errors mentioned in issue #64

What this fixes and how it's fixed

The main problem was from the state_income_tax variable.

CO fixes:

  • Changed out the tax variables to be more consistent with the 2022 worksheet found here.
  • Switched out variables that reference current income tax such as state_income_tax for variables that reference last year's .

MO fixes:

  • Changed state_income_tax for prior_year_state_income_tax_paid to break the circularity.

For both CO and MO I updated the baseline unit test variables to reflect those used in formula definitions.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66c48e7) 98.37% compared to head (17e52bc) 98.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   98.37%   98.37%   -0.01%     
==========================================
  Files        1773     1773              
  Lines       26463    26462       -1     
  Branches      176      176              
==========================================
- Hits        26034    26033       -1     
  Misses        398      398              
  Partials       31       31              
Flag Coverage Δ
unittests 98.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...states/co/tax/income/additions/co_state_addback.py 100.00% <100.00%> (ø)
...income/taxable_income/mo_net_state_income_taxes.py 100.00% <100.00%> (ø)
...ariables/gov/states/tax/income/state_income_tax.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickecon
Copy link
Collaborator

@mitchellpound. This looks great. I ran all the test locally on my machine as well. Everything passes. I submitted a PR to your branch that updates the version in setup.py and adds new entries to the CHANGELOG.md and changelog.yaml files. Once you merge that into your branch, I'll merge this PR.

@rickecon rickecon linked an issue Oct 24, 2023 that may be closed by this pull request
@mitchellpound
Copy link
Contributor Author

@rickecon Thanks! Just merged in your PR with the version and change log stuff.

@rickecon
Copy link
Collaborator

@mitchellpound. Thanks Mitch. Looks great. Merging.

@rickecon rickecon merged commit fe6d7e4 into TheCGO:main Oct 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix remaining circularities in CO and MO
2 participants