You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't remember where this breaks, but I remember it breaking when I tried it. I want FiscalSim to run on both Python 3.10 and Python 3.11 in the following two ways.
(i) I want our fiscalsim-us-dev conda environment from environment.yml to work for Python 3.10 or 3.11. I want the following code change in environment.yml. setup.py already does this. Once the change is implemented, I want you to make sure that all the tests in make test run on your local machine in a fiscalsim-us-dev conda environment in which the Python version is 3.11.
(ii) I want our GH Actions CI tests in build_and_test.yml to run on all three operating systems (already does) and on Python 3.10 and 3.11 (currently only runs on Python 3.10). I want the build_and_test.yml code to be changed to the following, and must pass all the tests:
name: Build and test [Python 3.10, 311]on: [push, pull_request]jobs:
build:
runs-on: ${{ matrix.os }}strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]python-version: ["3.10", "3.11"]steps:
- name: Checkoutuses: actions/checkout@v4with:
persist-credentials: false
- name: Set up Python using Python ${{ matrix.python-version }}uses: actions/setup-python@v4with:
python-version: ${{ matrix.python-version }}
- name: Install packagerun: make install
- name: Run testsrun: make test
- name: Upload coverage to Codecovuses: codecov/codecov-action@v3with:
files: ./coverage.xmlflags: unittestsname: codecov-umbrellafail_ci_if_error: trueverbose: true
I don't remember where this breaks, but I remember it breaking when I tried it. I want FiscalSim to run on both Python 3.10 and Python 3.11 in the following two ways.
fiscalsim-us-dev
conda environment fromenvironment.yml
to work for Python 3.10 or 3.11. I want the following code change inenvironment.yml
.setup.py
already does this. Once the change is implemented, I want you to make sure that all the tests inmake test
run on your local machine in afiscalsim-us-dev
conda environment in which the Python version is 3.11.build_and_test.yml
to run on all three operating systems (already does) and on Python 3.10 and 3.11 (currently only runs on Python 3.10). I want thebuild_and_test.yml
code to be changed to the following, and must pass all the tests:cc: @ss7886
The text was updated successfully, but these errors were encountered: