Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 capability #63

Closed
2 tasks
rickecon opened this issue Oct 16, 2023 · 0 comments · Fixed by #66
Closed
2 tasks

Add Python 3.11 capability #63

rickecon opened this issue Oct 16, 2023 · 0 comments · Fixed by #66

Comments

@rickecon
Copy link
Collaborator

I don't remember where this breaks, but I remember it breaking when I tried it. I want FiscalSim to run on both Python 3.10 and Python 3.11 in the following two ways.

  • (i) I want our fiscalsim-us-dev conda environment from environment.yml to work for Python 3.10 or 3.11. I want the following code change in environment.yml. setup.py already does this. Once the change is implemented, I want you to make sure that all the tests in make test run on your local machine in a fiscalsim-us-dev conda environment in which the Python version is 3.11.
name: fiscalsim-us-dev
dependencies:
  - python>=3.10,<3.12
  - pip
  • (ii) I want our GH Actions CI tests in build_and_test.yml to run on all three operating systems (already does) and on Python 3.10 and 3.11 (currently only runs on Python 3.10). I want the build_and_test.yml code to be changed to the following, and must pass all the tests:
name: Build and test [Python 3.10, 311]
on: [push, pull_request]
jobs:
  build:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [ubuntu-latest, macos-latest, windows-latest]
        python-version: ["3.10", "3.11"]

    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          persist-credentials: false
      - name: Set up Python using Python ${{ matrix.python-version }}
        uses: actions/setup-python@v4
        with:
          python-version: ${{ matrix.python-version }}
      - name: Install package
        run: make install
      - name: Run tests
        run: make test
      - name: Upload coverage to Codecov
        uses: codecov/codecov-action@v3
        with:
          files: ./coverage.xml
          flags: unittests
          name: codecov-umbrella
          fail_ci_if_error: true
          verbose: true

cc: @ss7886

@rickecon rickecon linked a pull request Oct 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant