Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark label/title as RenderableType #5148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thejcannon
Copy link

@thejcannon thejcannon commented Oct 21, 2024

👋 Howdy!

I spent an embarrassingly long time figuring out how to get a Static to be the title of a Collapsable, so much so I forked this repo and prepared a change to support it (which, I might add, didn't work).

And then after staring at my own code for long enough it hit me. The title is already a Static, so label/title must be a RenderableType.

Since RenderableType includes str this should be 100% backwards compatible with all existing usage.

@darrenburns
Copy link
Member

Hey, this is marked as a draft - is it ready for review?

@thejcannon
Copy link
Author

thejcannon commented Nov 7, 2024

Oh yeah! My bad. I usually mark draft and make sure CI is passing before opening for review, but forgot to mark after CI.

@darrenburns darrenburns marked this pull request as ready for review November 7, 2024 16:27
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need to type the label reactive with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants