-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a detail column to the Tree widget #5096
base: main
Are you sure you want to change the base?
Conversation
b1b526d
to
2abc47e
Compare
Interesting! Where does the detail column start? Is it different for each row or aligned with the maximum extend of the labels? Any change of a vide of this in action? |
The detail column is calculated by finding the number of spaces required to fit the The magic minus 3 was by eye-balling the result (😄) I can create a video showing the result, |
DetailTree480p.movSorry about the quality, there was a 10 MB limit to the size of the file. I see now that the handling of narrow views are a bit sub-optimal. |
2abc47e
to
baf968d
Compare
Let me know if there is a preferred strategy to handle narrow views. During implementation I thought about different ways of solving this, this was the simplest one with minimal impact. However, I recognise that it adds API changes that could be difficult to move away from if there are plans to solve the same problem in a more flexible way in the future. Let me know how I may adapt the implementation to better accommodate such plans. I can also add support for file sizes to the DirectoryTree in this PR (or another) if that is interesting. |
baf968d
to
8a0baf7
Compare
8a0baf7
to
215f8c2
Compare
This PR adds a detail column justified to the right of the tree view. It provides a simple way of showing additional information that relates to the node. Example use cases could be amounts, temperature, sizes and more.
The following image is the result of the example provided in the documentation.
Please review the following checklist.