BUG (?): refresh and max-height

[nitzan-shaked]

(first of all: I'm happy to attach screenshots, videos, minimal code to repro, etc. -- just not sure how this community works. Apologies in advance!)

It looks like the following misbehaves:
a Static with height: auto,
nested in a Vertical with height: auto,
itself nested in a Vertical with height: auto; max-height: 10

Specifically: set the context of the Static to something long (say 20 lines of text), which displays nicely and adds a scrollbar as expected. Then, set the content of the Static to "Hello" -- it works, but everything remains "too tall". A simple refresh (just resize the terminal a bit) solves this.

Given that a simple terminal resize "fixes" this I am assuming that's not intended behavior.

Specifically, changing the code of Widget._clear_arrangement_cache to:

    def _clear_arrangement_cache(self) -> None:
        """Clear arrangement cache, forcing a new arrange operation."""
        self._arrangement = None
        # THE BELOW IS NEW
        if isinstance(self._parent, Widget):
            self._parent._clear_arrangement_cache()

Seems to solve, but honestly I'm not sure that's the right solution. If I'm anywhere in the right direction then there should be a "force_layout" method which will do this, and set ._layout_required, and probably do something with Screen (post a message? Set its layout_required? Donno.)

So, questions:

1. Am I missing the obvious? If so -- what is it?
2. And while I'm here -- are you interested in PR contribs? Eg fixing this; or -- stuff for TreeControl which I've added; or for DataTable.
3. If so -- how? Where's the guide you'd like me to follow? (tests, conventions, ci, ...)

Cheers!

[davep]

I'm happy to attach screenshots, videos, minimal code to repro

Minimal code to reproduce is always a win; with accompanying steps to follow and/or screenshots/video/etc is always super helpful.

[willmcgugan]

@nitzan-shaked Can you reproduce this with 0.7.0 ?

[nitzan-shaked]

@willmcgugan yes, just checked "main" on GItHub which according to pyproject.toml is 0.7.0.
Have you looked at my proposed fix? Regardless of whether it is correct or not, it should give a hint as to what's going on.

[nitzan-shaked]

@willmcgugan what's the next step here plz?

[willmcgugan]

There will be a fix in 0.8.0 which will be released in a day or two.

[nitzan-shaked]

Looks like it's fixed indeed. Or least: works for me :) Thank you.