Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update GCC_Toolchain instructions for AM335x/AM437x/AM57x #149

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix: Update GCC_Toolchain instructions for AM335x/AM437x/AM57x #149

merged 2 commits into from
Jan 10, 2025

Conversation

jeevantelukula
Copy link
Collaborator

Fix the invalid architectural references and update cross-compile instructions.

For final docs page view checkout: https://jeevantelukula.github.io/processor-sdk-doc-fork/processor-sdk-linux-AM335X/esd/docs/09_03_05_02/linux/Overview/GCC_ToolChain.html

@jeevantelukula
fix: Update GCC_Toolchain instructions for AM335x/AM437x/AM57x
3105fdb 
Fix the invalid architectural references and update cross-compile instructions.

Signed-off-by: Telukula Jeevan Kumar Sahu <j-sahu@ti.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

New warnings found with rstcheck:

source/linux/Overview/GCC_ToolChain.rst:58: (INFO/1) Duplicate implicit target name: "linux-devkit".
source/linux/Overview/GCC_ToolChain.rst:271: (INFO/1) Duplicate implicit target name: "k3r5-devkit".

cshilwant
cshilwant previously requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeevantelukula I see many more references of ARMv8 in your preview in other sections as well.

Ref - https://jeevantelukula.github.io/processor-sdk-doc-fork/processor-sdk-linux-AM335X/esd/docs/09_03_05_02/search.html?q=armv8&check_keywords=yes&area=default

Please plan to handle & update all such armv8 references

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

New warnings found with rstcheck:

source/linux/Overview/_Processor_SDK_Linux_Directory_Structure.rst:84: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.
source/linux/Overview/GCC_ToolChain.rst:58: (INFO/1) Duplicate implicit target name: "linux-devkit".
source/linux/Overview/GCC_ToolChain.rst:271: (INFO/1) Duplicate implicit target name: "k3r5-devkit".

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

New warnings found with rstcheck:

source/linux/Overview/GCC_ToolChain.rst:58: (INFO/1) Duplicate implicit target name: "linux-devkit".
source/linux/Overview/GCC_ToolChain.rst:271: (INFO/1) Duplicate implicit target name: "k3r5-devkit".

@cshilwant
Copy link
Member

@aniket-l for reviewing AM57x specific changes

@cshilwant cshilwant dismissed their stale review January 6, 2025 06:31

PR is updated

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

New warnings found with rstcheck:

source/linux/Overview/GCC_ToolChain.rst:58: (INFO/1) Duplicate implicit target name: "linux-devkit".
source/linux/Overview/GCC_ToolChain.rst:269: (INFO/1) Duplicate implicit target name: "k3r5-devkit".

@cshilwant cshilwant requested a review from jmenti January 7, 2025 21:28
StaticRocket
StaticRocket previously requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue. Otherwise this seems good.

source/linux/Foundational_Components/Kernel/_Users_Guide.rst Outdated Show resolved Hide resolved
@jeevantelukula
fix: AM335x/AM437x/AM57x: Update Directory Structure and ARM architec…
289f93f 
…tural references

Signed-off-by: Telukula Jeevan Kumar Sahu <j-sahu@ti.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

New warnings found with rstcheck:

source/linux/Overview/GCC_ToolChain.rst:58: (INFO/1) Duplicate implicit target name: "linux-devkit".
source/linux/Overview/GCC_ToolChain.rst:269: (INFO/1) Duplicate implicit target name: "k3r5-devkit".

@cshilwant cshilwant dismissed StaticRocket’s stale review January 8, 2025 20:04

Author has updated the PR

@cshilwant cshilwant merged commit f462d72 into TexasInstruments:master Jan 10, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaticRocket StaticRocket StaticRocket approved these changes

@cshilwant cshilwant cshilwant approved these changes

@praneethbajjuri praneethbajjuri Awaiting requested review from praneethbajjuri praneethbajjuri is a code owner

@uditkumarti uditkumarti Awaiting requested review from uditkumarti uditkumarti is a code owner

@aniket-l aniket-l Awaiting requested review from aniket-l aniket-l is a code owner

@VeeruPrudhvi VeeruPrudhvi Awaiting requested review from VeeruPrudhvi VeeruPrudhvi is a code owner

@jmenti jmenti Awaiting requested review from jmenti

Assignees

@praneethbajjuri praneethbajjuri

@devarsht devarsht

@r-vignesh r-vignesh

@aniket-l aniket-l

@uditkumarti uditkumarti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jeevantelukula @cshilwant @StaticRocket @jmenti @praneethbajjuri @devarsht @r-vignesh @aniket-l @uditkumarti