Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PRU-ICSS): Remove the PRU-ICSS table that comes up on Sitara Legacy devices docs index page for now #134

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jeevantelukula
Copy link
Collaborator

Currently there was no support on these protocols, so remove from the docs index page until further clarity.

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeevantelukula Nitpick,

commit message title looks too long.

Checkout previous commits by other authors to get more idea - https://github.com/TexasInstruments/processor-sdk-doc/commits/master/

Also, I would personally encourage you to checkout - torvalds/linux#17 (comment)

jsuhaas22
jsuhaas22 previously approved these changes Dec 17, 2024
@cshilwant
Copy link
Member

@nsaulnier-ti @liubiin for reviews

@nsaulnier-ti
Copy link
Contributor

@jeevantelukula is PTP and RSTP still tested on CPSW for AM335x & AM437x?

If so, I would rather that we just remove CCLink & OPC/UA, and keep the PTP and RSTP pages. Just update the note at the top of the PTP page to say the information only applies to CPSW, instead of "only applies to CPSW on SDK 9.1"

@danish-ti
Copy link
Contributor

@nsaulnier-ti PTP / RSTP is not tested on CPSW in this release. AFAIK, it was last tested during 8.x SDK. Same is true for ICSSM as well. We are not doing any active testing on legacy platforms (except AM65x)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…nd toc

Currently there was no support on PRU-ICSS protocols,
so remove from the docs until further clarity.

Signed-off-by: Telukula Jeevan Kumar Sahu <j-sahu@ti.com>
@jeevantelukula
Copy link
Collaborator Author

@nsaulnier-ti PTP / RSTP is not tested on CPSW in this release. AFAIK, it was last tested during 8.x SDK. Same is true for ICSSM as well. We are not doing any active testing on legacy platforms (except AM65x)

@nsaulnier-ti Since PTP/RSTP are not tested on CPSW also, I removed those pages along with CCLink & OPC/UA pages from 335x/437x docs. As there is active testing for AM65x platform, these sections are maintained in docs.

@cshilwant cshilwant requested a review from a team December 20, 2024 03:24
@cshilwant
Copy link
Member

@jsuhaas22 @paresh-bhagat12 for reviews

Copy link
Collaborator

@jsuhaas22 jsuhaas22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshilwant cshilwant merged commit 43e1e2a into TexasInstruments:master Dec 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants