Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign <blank> instead of, e.g., 0 to mean unused #35

Open
10 tasks
willf opened this issue Feb 12, 2025 · 0 comments
Open
10 tasks

Assign <blank> instead of, e.g., 0 to mean unused #35

willf opened this issue Feb 12, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@willf
Copy link

willf commented Feb 12, 2025

Pull Request Description

It's confusing to assign 0 to an argument to mean unused. So we'll set values to <blank> for unused arguments.
It's no longer possible to use "auto" to mean unused; "auto" can only mean "use OS-HPXML default".

Dehumidifier
Before
image
After
image

Related Pull Requests

OS-HPXML: NREL/OpenStudio-HPXML#1867.
Supersedes https://github.com/Test-Cloned-Org/resstock/pull/1312.

Related Issues

Closes NREL#1289.
Closes NREL#1293.

Checklist

Required:

Optional (not all items may apply):

Source: NREL on 2024-10-25.

@willf willf added the bug Something isn't working label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant