Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new config parameter defaultBaseMapId #4995

Closed
wants to merge 4 commits into from
Closed

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Nov 18, 2020

What this PR does

Adds a new config parameter defaultBaseMapId which is used as a fallback if no persisted map is found.

Required for TerriaJS/RaPPMap#87

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

@zoran995
Copy link
Collaborator

zoran995 commented Nov 18, 2020

This can't be done through init files like in v7? Or this should be third way do define the basemap? There is #4947 to port it.

@na9da
Copy link
Collaborator Author

na9da commented Nov 18, 2020

Ooh! That's right, I forgot that baseMapName existed. I'll close this PR in favor of #4947.

@na9da na9da closed this Nov 18, 2020
@na9da na9da deleted the default-basemap-config branch January 27, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants