-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share keys #4975
Share keys #4975
Conversation
This could be fixed equally well without also adding await, but await is nice
6c97206
to
bea2150
Compare
Revert #4979 after merging this. Related to this issue https://github.com/TerriaJS/qld-digital-twin/issues/237 After reverting close this issue - #4978 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! thanks @steve9164
Just a few small things + Changes.md entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was being too nitpicky - all good
Thanks crispy
What this PR does
Fixes #4774.
Ports
shareKeys
from version 7.This PR is now a draft because I haven't updated CHANGES.md and I'm not sure whether to change how share data loading uses
upsertModelFromJson
while I'm here:upsertModelFromJson
Apart from that, this functionality should work well in the following scenarios:
catalog-converter
)init-to-magda
)Magda catalog share link where the item has moved is partially supported, but only if old share link ids manage to match against
shareKeys
in parts of the catalog already loaded when the share data is applied.Checklist