Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CatalogFunctions and YourDataYourRegions #4406

Merged
merged 93 commits into from
Nov 3, 2020
Merged

New CatalogFunctions and YourDataYourRegions #4406

merged 93 commits into from
Nov 3, 2020

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Jun 3, 2020 •
edited
Loading

See Issue #4861 for discussion + progress notes

Testing: http://ci.terria.io/mobx-ydyr/#clean&https://gist.githubusercontent.com/nf-s/36eabf17577e78a5cde482928d96ff52/raw/76148d64dabc45ac0d9eb4f087cfb95b297beb47/catfun.json

Mobx / TypeScriptify FunctionParameters

Note: I may not complete all of these

  • Boolean Parameter
  • Function Parameter
  • InfoParameter
  • RegionDataParameter
  • BooleanParameterGroup
  • createParameterFromType

Mobx / TypeScriptify Parameters Editors

Note: I may not complete all of these either

  • ParameterEditor
  • EnumParamEditor
  • BooleanParamEditor
  • BooleanGroupParamEditor
  • InfoParameterEditor
  • GenericParamEditor
  • LineParamEditor
  • PointParamEditor
  • RegionParamEditor
  • GeoJsonParamEditor
  • PolygonParamEditor
  • DateTimeParamEditor
  • RectangleParamEditor
  • RegionDataParamEditor
  • RegionTypeParamEditor
  • SelectAPolygonParamEditor

nf-s added 30 commits April 17, 2020 13:35
@nf-s
Create CatalogFunction Mixin and Traits
3fc82df
@nf-s
update FunctionParameter + mobxify EnumParamEditor
8e91f24
@nf-s
mobxify Boolean and Enumeration parameters
6a779a4
@nf-s
mobxify genericParamEditor + fixed enumparameditor
0695668
@nf-s
fix my wrong assumption about resultPendingCatalogItem in CatalogFunc…
fdfa2a9 
…tionMixin
@nf-s
pprettier
2d9bce1
@nf-s
fix wpscatfunction type error
aedf2ee
@nf-s
fix wpscatfunction error
f483bff
@nf-s
Merge branch 'mobx' into mobx-catfunction
78bff80
@nf-s
rename resultpendingcatalogitem to catalogfuncitonjob
8abc9cc
@nf-s
create catalogfunctionjobmixin + add toggle for AutoRefreshMixin
4a889b5
@nf-s
fix AutoRefreshingTrais
c3faeb8
@nf-s
messing around with catalog funtions + params
3539527
@nf-s
Merge remote-tracking branch 'origin/mobx' into mobx-catfunction
539b089
@nf-s
Merge branch 'mobx-catfunction' into mobx-catfunction-experient
394fbf6
@nf-s
re-add ResultPendingCatalogItem
2191026
@nf-s
no type errors now
b4db77e
@nf-s
wps working with new FunctionParameters
0320556
@nf-s
YDYR catalog function working
da0b45e
@nf-s
updateYDYR cat fun
b27edd8
@nf-s
flat merge selectabledimensions
656d2b4
@nf-s
not working with anyTrait
b8ad737
@nf-s
clean up + fix EnumerationParam value reaction
c02d019
@nf-s
add AsyncMappable to AutoRefreshMixin (because it depends on it)
3acf41d
@nf-s
dodgy notification z-index fix
e237a73
@nf-s
add headers to loadText
e5bd2fd
@nf-s
YDYR now polls using AutoRefreshMixin + sharing now works for jobs wh…
db296e8 
…ich are polling! (but not finished jobs)
@nf-s
YDYR state working
47980f4
@nf-s
added isMixedInto AsyncMappableMixin
0c42784
@nf-s
tsxify shortReport + add show trait
7c37b47
@nf-s nf-s marked this pull request as ready for review October 25, 2020 13:05
@nf-s nf-s changed the title New CatalogFunctions and YourDataYourRegions WIP New CatalogFunctions and YourDataYourRegions Oct 25, 2020
@nf-s nf-s added the Version 8 formerly MobX label Oct 25, 2020
@nf-s
Copy link
Contributor Author

nf-s commented Oct 25, 2020

This fixes #1542

KeyboardSounds
KeyboardSounds suggested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@KeyboardSounds KeyboardSounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1 of my review. Stay tuned for the thrilling sequel tomorrow ✨

KeyboardSounds
KeyboardSounds approved these changes Oct 29, 2020
View reviewed changes
KeyboardSounds
KeyboardSounds suggested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@KeyboardSounds KeyboardSounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button, sorry 😬

@nf-s nf-s mentioned this pull request Oct 30, 2020
Closed
15 tasks
@KeyboardSounds KeyboardSounds self-requested a review November 3, 2020 01:14
@nf-s nf-s merged commit 91ec289 into next Nov 3, 2020
@nf-s nf-s deleted the mobx-ydyr branch November 3, 2020 22:19
@nf-s nf-s mentioned this pull request Nov 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na9da na9da na9da left review comments

@KeyboardSounds KeyboardSounds KeyboardSounds approved these changes

Assignees

@na9da na9da

@KeyboardSounds KeyboardSounds

Labels
C-Analytics P-YourDataYourRegions Version 8 formerly MobX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-s @na9da @KeyboardSounds