Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lodash from rollup config #4960

Merged
merged 2 commits into from
Jan 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
"dependencies": {
"@babel/runtime": "^7.22.6",
"@popperjs/core": "^2.11.8",
"@types/lodash-es": "^4.17.12",
"@types/sortablejs": "^1.15.1",
"@types/tinycolor2": "^1.4.3",
"@types/validator": "^13.7.17",
Expand Down Expand Up @@ -119,6 +118,7 @@
"@rollup/plugin-url": "^7.0.0",
"@testing-library/dom": "^8.20.1",
"@types/babel__traverse": "~7.20.6",
"@types/lodash-es": "^4.17.12",
"@types/node": "22.5.1",
"@types/raf": "^3.4.0",
"@typescript-eslint/eslint-plugin": "^4.33.0",
Expand Down
6 changes: 3 additions & 3 deletions script/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import pkg from '../package.json';
const name = 'tdesign';

const esExternalDeps = Object.keys(pkg.dependencies || {});
const externalDeps = esExternalDeps.concat([/lodash/, /@babel\/runtime/]);
const externalDeps = esExternalDeps.concat([/@babel\/runtime/]);
const externalPeerDeps = Object.keys(pkg.peerDependencies || {});
const banner = `/**
* ${name} v${pkg.version}
Expand Down Expand Up @@ -233,7 +233,7 @@ const umdConfig = {
banner,
format: 'umd',
exports: 'named',
globals: { vue: 'Vue', lodash: '_' },
globals: { vue: 'Vue' },
sourcemap: true,
file: `dist/${name}.js`,
},
Expand All @@ -253,7 +253,7 @@ const umdMinConfig = {
banner,
format: 'umd',
exports: 'named',
globals: { vue: 'Vue', lodash: '_' },
globals: { vue: 'Vue' },
sourcemap: true,
file: `dist/${name}.min.js`,
},
Expand Down
Loading