Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dropdown): add boolean attribute convert #3702

Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat(Dropdown): add boolean attribute convert #3702

merged 1 commit into from
Dec 7, 2023

Conversation

Zz-ZzzZ
Copy link
Contributor

@Zz-ZzzZ Zz-ZzzZ commented Dec 7, 2023 •
edited
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#3692

💡 需求背景和解决方案

📝 更新日志

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@Zz-ZzzZ
Copy link
Contributor Author

Zz-ZzzZ commented Dec 7, 2023 •
edited
Loading

这里只处理了DropdownItem组件，其它组件传递boolean attribute时没有处理，通常情况Dropdown里应该只会跟着DropdownItem (若是处理所有组件可能就需要像Vue源码内部一样处理boolean attribute)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

完成

uyarn
uyarn reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn
Copy link
Collaborator

uyarn commented Dec 7, 2023

这里只处理了DropdownItem组件，其它组件传递boolean attribute时没有处理，通常情况Dropdown里应该只会跟着DropdownItem (若是处理所有组件可能就需要像Vue源码内部一样处理boolean attribute)

不过不是所有组件都需要这样 这里是拿子组件去转换成序列了

@uyarn uyarn merged commit e9c10dc into Tencent:develop Dec 7, 2023
5 checks passed
@Zz-ZzzZ Zz-ZzzZ deleted the fix/dropdown-attribute branch December 7, 2023 05:21
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zz-ZzzZ @uyarn