B2PDE-1447 implements getAppDomain #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossgcia
force-pushed
the
B2PDE-1447-getAppDomain
branch
from
4f566b6 to
3753b51
Compare
jprietoTuenti
approved these changes
Feb 7, 2025
alexanegon
approved these changes
Feb 11, 2025
| ```ts | ||
| getAppDomain: () => Promise<{domain: string}>; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Suggested change
| - `domain`: the domain value of the environment that the app is pointing to. |
src/__tests__/device-test.ts
Outdated
| type: 'GET_APP_DOMAIN', | ||
| id: msg.id, | ||
| payload: { | ||
| appDomain: '123', |
There was a problem hiding this comment.
If we expect an URL IMHO I would use https://example.com if there is any string user ANY_STRING
Suggested change
| appDomain: '123', | |
| appDomain: 'https://example.com', |
jdelga
approved these changes
Feb 11, 2025
atabel
reviewed
Feb 13, 2025
There was a problem hiding this comment.
remember to export the new method in index.ts
https://github.com/Telefonica/webview-bridge/blob/master/index.ts#L28
atabel
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
getAppDomainfunction, which allows retrieving the domain of the application where the WebView bridge is running. This functionality is useful for identifying the application context and adjusting specific behaviors based on the domain.closes #195