feat(qualtrics methods): displayQualtricsIntercept, setQualtricsProperties, isQualtricsInterceptAvailableForUser #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ricsProperties, isQualtricsInterceptAvailableForUser
dpastor
reviewed
Dec 12, 2024
README.md
Outdated
| @@ -1479,6 +1479,93 @@ validateDatamobRequirements: ({phoneNumber: string, tokenPassword: string}) => P | |||
|
|
|||
| - `requirements`: A map with the requirements. | |||
|
|
|||
| ### displayQualtricsIntercept | |||
|
|
|||
| <kbd>App version >=24.12</kbd> | |||
There was a problem hiding this comment.
All methods will be available only for iOS by the moment. In android it's expected to be integrated at some next version.
We can add a "Only for iOS" comment, and when it is integrated in android we can update the doc with the proper version.
pladaria
approved these changes
Dec 12, 2024
dpastor
reviewed
Dec 12, 2024
src/qualtrics.ts
Outdated
Comment on lines
23
to
25
| stringProperties: Array<QualtricsProperty<string>>; | ||
| numberProperties: Array<QualtricsProperty<number>>; | ||
| dateTimePropertyKeys: Array<string>; |
There was a problem hiding this comment.
I see we didn't specified that in the spec, but probably is interesting to give these properties a default value (empty array) from js side? WDYT @dhidalgofadrique
dpastor
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks a lot! Please just check this comment -> #185 (comment)
dhidalgofadrique
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.tid.es/browse/WEB-2119
closes #178
closes #179
closes #184