Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): make warning token accesible in O2-new #2047

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

yceballost
Copy link
Collaborator

@yceballost yceballost commented Jan 30, 2025

Pull Request Description: fix(colors): make warning token accessible in O2-new

Motivation

The goal of this change is to enhance the accessibility of color tokens in the O2-new design system, specifically by updating the warning token to use a more defined color value. This will improve the consistency and clarity of the color palette in our applications.

Changes Made

  1. Updated Warning Color Token: The warning token has been changed from palette.o2Orange to palette.o2Orange60. This adjustment ensures that the warning color is more visually distinct and aligns better with accessibility requirements.

  2. Added New Color Definition: The color o2Orange60 has been introduced with a specific hex value (#F06C00), making it available for use across the system.

  3. Schema Updates: The schema definitions have been updated to include o2Orange60 in the pattern matching, ensuring it is recognized within the O2-new token structure.

Benefits

  • Improved Visual Hierarchy: By specifying the o2Orange60 as the warning color, we enhance the visual hierarchy and ensure that warnings are more noticeable to users.
  • Consistency Across the System: This change aligns the color token usage with the broader design language, fostering a cohesive user experience.
  • Future-proofing: By clearly defining the new color value and updating the schema, we facilitate easier future modifications and additions to the color palette.

This update is a step towards a more robust and user-friendly design system, and it will help maintain a high standard for our UI components.

@yceballost yceballost requested a review from aweell January 30, 2025 15:40
@yceballost yceballost added this pull request to the merge queue Jan 30, 2025
Merged via the queue into production with commit ecb785b Jan 30, 2025
9 checks passed
@yceballost yceballost deleted the change-warning-token-a11y branch January 30, 2025 15:43
@yceballost yceballost linked an issue Jan 31, 2025 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change warning token color in o2-new
2 participants