Remove require for conf in jwttokenmanager.js #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TekMonksGitHub
requested changes
Jul 23, 2024
| @@ -28,7 +28,7 @@ function initSync() { | |||
|
|
|||
| if (TOKENMANCONF.useGlobalMemory) TOKEN_MEMORY = _ => DISTRIBUTED_MEMORY; else TOKEN_MEMORY = _ => CLUSTER_MEMORY; | |||
|
|
|||
| try {conf = require(TOKENMANCONF);} catch (err) {conf = {}} | |||
| try {conf = TOKENMANCONF;} catch (err) {conf = {}} | |||
There was a problem hiding this comment.
Catch is redundant, secondly having 2 variables - conf and TOKENMANCONF is also wrong.
If you are submitting a fix - please fix correctly.
There was a problem hiding this comment.
Hi Rohit,
It is better to remove the conf variable and directly use TOKENMANCONF and we can remove the try-catch block as the conf variable is not required. We can use the below code:
TOKENMANCONF.expiryInterval = TOKENMANCONF?.expiryInterval || DEFAULT_TOKEN_EXPIRY;
TOKENMANCONF.tokenGCInterval = TOKENMANCONF?.tokenGCInterval || DEFAULT_GC_INTERVAL;
setInterval(_cleanTokens, TOKENMANCONF.tokenGCInterval);
```
Could you please review the above code?
There was a problem hiding this comment.
Ok, Rohit. Closing this PR and raising a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.