[Soundcloud] Remove DRM-protected and downloadable formats extraction #1269
+38
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRM-protected streams have been added to some tracks, mostly from major music companies. We do not support DRM streams in the extractor, so they shouldn't be extracted and so waste time, energy and resources. Extracting downloadable format requires login for a pretty long time, so there is no point again to do requests to extract this stream to get an unauthorized response. Also send the track_authorization property returned in the track info, like the website does and allow duplicate MP3 formats in progressive and HLS delivery methods to be returned.
AudricV
added
bug
Stypox
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some of SoundCloud tracks. DRM-protected streams have been added to some tracks, mostly from major music companies. As we do not support DRM streams in the extractor, they shouldn't be extracted so this PR removes them.
Downloading formats used to work anonymously, but Soundcloud restricted it to logged-in users. While it was a UI-only change, this affects the corresponding internal API endpoint for a few months, so there is no point to make a request that will always return a HTTP 401 response.
Loading affected tracks will now be faster as there is no additional request made to get URL for these streams.
The service started to use for a while to send a
track_authorizationproperty returned in the track info (at least on mobile and desktop websites), this PR makes the extractor do so too. It isn't required for now, but it may become mandatory at some point in the future.Duplicate MP3 formats in progressive and HLS delivery methods were not allowed to be returned since cbacd3c. As the extractor now completely supports them, it should return everything that is available to it.
The corresponding stream tests affected by these changes, in
SoundcloudStreamExtractorTest, have been updated.