모집의뢰서, 기업리스트 엑셀 다운로드 버그 수정 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
phyuna0525
requested review from
KANGYONGSU23,
JJIIIINN,
jikwan0327,
dnjsdmswl and
eejx0
teamreturn
reviewed
Jul 9, 2024
Comment on lines
+185
to
+190
| const link = document.createElement('a'); | ||
| link.href = url; | ||
| link.setAttribute('download', '모집기업의뢰서.xlsx'); | ||
| document.body.appendChild(link); | ||
| link.click(); | ||
| document.body.removeChild(link); |
There was a problem hiding this comment.
이 부분 코드를 utils에서 downloadFile로 파일 분리해보는 것은 어떨까요? 반복되는 부분도 있어서 분리할 수 있을 거 같아요. 함수 인자로는 다운로드 파일 이름과 url을 받으면 될듯합니다.
dnjsdmswl
approved these changes
Aug 13, 2024
eejx0
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
특이사항
관련 이슈