Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
added 2 commits
May 28, 2024 16:47
jikwan0327
requested review from
KANGYONGSU23,
JJIIIINN,
jikwan0327,
dnjsdmswl and
eejx0
jikwan0327
reviewed
May 29, 2024
src/Apis/Applications/response.ts
Outdated
Comment on lines
30
to
32
| export interface CntType { | ||
| count: number; | ||
| } |
There was a problem hiding this comment.
cnt와 같은 약어 보다는 네이밍이 길어지더라도 명확한 네이밍이 좀 더 좋을 거 같아요.
|
전체적으로 네이밍만 조금 더 신경쓰면 괜찮을 거 같아요 |
jikwan0327
approved these changes
May 29, 2024
KANGYONGSU23
approved these changes
May 30, 2024
jikwan0327
reviewed
Jun 3, 2024
src/Apis/Applications/response.ts
Outdated
| @@ -27,6 +27,6 @@ export interface InternshipStudentType { | |||
| student_gcn: string; | |||
| } | |||
|
|
|||
| export interface CntType { | |||
| export interface applicationCountType { | |||
JJIIIINN
reviewed
Jun 3, 2024
| @@ -114,6 +116,13 @@ export function ApplicationViewTable({ | |||
| } | |||
| ); | |||
| const { isLoading: requestStatusIsLoading } = changeStatusAPI; | |||
There was a problem hiding this comment.
그냥 위에서 구조분해 할당 해주면 될 것 같은데 이렇게 쓴 이유가 있나요?
| kind="Ghost" | ||
| size="S" | ||
| disabled={buttonDisabled} | ||
| onClick={changeContractAPI.mutate} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
특이사항
관련 이슈