배너 퍼블리싱 #39
Merged
배너 퍼블리싱 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eejx0
approved these changes
Feb 21, 2024
JJIIIINN
reviewed
Feb 23, 2024
src/Components/Banner/index.tsx
Outdated
Comment on lines
14
to
17
| <_.BannerImg src={banner} /> | ||
| <_.BannerImg src={banner} /> | ||
| <_.BannerImg src={banner} /> | ||
| <_.BannerImg src={banner} /> |
There was a problem hiding this comment.
p2) Array.form으로 하는 게 더 좋아보여요.
There was a problem hiding this comment.
배너가 다 다르다면 따로 constant 폴더에 파일 하나 만들고 그 파일에서 배열로 관리하면 좋을 것 같아요.
그걸 import 해서 map으로 돌리면 유지보수적으로도 좋아요.
Comment on lines
+14
to
+22
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> | ||
| <_.TempleteImg src={banner} /> |
|
p1) 전체적으로 디자인 시스템을 안 쓰고 있는데 한 번 써보면 좋을 것 같아요. |
jikwan0327
requested changes
Feb 25, 2024
Comment on lines
+63
to
+70
| { | ||
| path: 'Banner', | ||
| element: <BannerPage />, | ||
| }, | ||
| { | ||
| path: 'CreateBanner', | ||
| element: <CreateBannerPage />, | ||
| }, |
There was a problem hiding this comment.
위의 이름도 잘못 되었지만 원래 path 네이밍은 대문자가 들어가면 안됩니다. 또한 소문자로만 구성하며 구분자로 사용할 때에는 하이픈(-)을 사용하는 것이 좋아요.
참고 글이니 확인해보세요
https://velog.io/@caesars000/RESTful-API-%EA%B0%80%EC%9D%B4%EB%93%9C
parkuiery
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
특이사항
관련 이슈