Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide prod configs from git #389

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anklav24
Copy link

@anklav24 anklav24 commented Nov 6, 2024

Allow the creation of configs in git submodule locally.

cd YOUR_MAIN_REPO
mkdir configs
cd configs/
git init
touch config.main_server_1.conf
git add .
git commit -m "init: add config for first server"
cd ..
git submodule add ./configs configs

@werewolfboy13
Copy link
Collaborator

With the new commit is there a reason needed in this PR since this appears to be a local setup change?

@anklav24
Copy link
Author

anklav24 commented Nov 8, 2024

With the new commit is there a reason needed in this PR since this appears to be a local setup change?

Need to hide the submodule changes from the main repo and show that such a directory can exists as a submodule.

Since the configs are large and may differ across different servers, I want to maintain the ability to see changes via git diff.

Copy link
Collaborator

@werewolfboy13 werewolfboy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting further information

@werewolfboy13
Copy link
Collaborator

I just saw that as I put the change request in...

@anklav24
Copy link
Author

anklav24 commented Nov 8, 2024

I just saw that as I put the change request in...

After this commit for fresh installed SquadJS users can do the following

cd YOUR_MAIN_REPO
mkdir configs
cd configs/
git init
cp ../config.json config.dev.json

And can see e.g. in the VSCode
Screenshot 2024-11-08 115811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants