Feature/177 : 애플로그인 사용자명 랜덤 세팅 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
CYY1007
reviewed
Mar 11, 2024
| @@ -87,8 +92,12 @@ private Member loginWithApple(MemberRequest.LoginDTO request) { | |||
| Optional<Member> foundMember = | |||
| memberRepository.findBySocialIdAndSocialType(appleSocialId, SocialType.APPLE); | |||
|
|
|||
| String nickName = ""; | |||
| List<String> nickNameWords = nickNameClient.getNickName(NICK_NAME_FORMAT, NICK_NAME_COUNT, NICK_NAME_MAX_LENGTH).getWords(); | |||
| if(!nickNameWords.isEmpty()) nickName = nickNameWords.get(0); | |||
There was a problem hiding this comment.
닉네임이 빈 리스트인 경우는 어떻게 될까요?
nickNameWords.stream().findFirst();를 이용하여 null인 경우에 대해 예외처리를 안해도 될지 궁금합니다!
CYY1007
reviewed
Mar 11, 2024
| */ | ||
| private String getOneRandomNickNameWithDetails(int maxLength) { | ||
| List<String> nickNameWords = nickNameClient.getNickName(NICK_NAME_FORMAT, NICK_NAME_COUNT, maxLength).getWords(); | ||
| if (!nickNameWords.isEmpty()) return nickNameWords.get(0); |
There was a problem hiding this comment.
앞선 리뷰와 동일한데, nickNameWords.stream().findFirst();를 사용하는 방식에 대해서는 어떻게 생각하시나요?
빈 리스트의 경우 ""를 반환할지 아니면 기본 닉네임을 반환할지도 고민이 되네요
ahnsugyeong
approved these changes
Mar 11, 2024
|
넵! 코멘트 반영해서 null 안 넘어오게 응답(words)에 빈 리스트 할당하고, 기본 닉네임 하품하는 프로도로 세팅해두었습니다!👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
애플로그인 시, 사용자명을 받을 수 없어 외부 API를 사용해 랜덤 사용자명을 세팅해줍니다.
⏳ 작업 내용
📝 논의사항